Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2.0] Show series, fields and tags with over 10k series in DB are truncated (unexpected behaviour) #7962

Closed
pkittenis opened this issue Feb 8, 2017 · 10 comments

Comments

@pkittenis
Copy link

pkittenis commented Feb 8, 2017

Bug report

System info: 1.2.0, Linux

Steps to reproduce:

  1. Insert 15k series into DB
  2. SHOW SERIES LIMIT 20000
  3. Length of series list returned is 10k

Expected behavior: Series list would return up to 20k series.

Actual behavior: Series list was truncated to 10k

Additional info: Not sure if this is a bug or expected behaviour but saw nothing in change log about SHOW queries now having a 10k max limit, regardless of limit set in query. With or without an explicit limit in the query, max series returned is always 10k.

Looking at the json returned by influxdb, it contains partial: true, but no messages in influxdb logs otherwise. Also, at least in the python influxdb client, there is no indication that partial results have been returned. The behaviour with 1.1.x is that a value of LIMIT number of series is returned. This has affected some influxdb clients on upgrading to 1.2.0.

SHOW FIELD KEYS and SHOW TAG KEYS are also similarly truncated to 10k.

@pkittenis pkittenis changed the title [1.2.0] Show series with over 10k series in DB has unexpected behaviour [1.2.0] Show series, fields and tags with over 10k series in DB has unexpected behaviour Feb 8, 2017
@joelio
Copy link

joelio commented Feb 8, 2017

We are also seeing similar behavior via Grafana. Large series of metrics that displayed perfectly in 1.1 now are truncated and partially rendered.

@pkittenis pkittenis changed the title [1.2.0] Show series, fields and tags with over 10k series in DB has unexpected behaviour [1.2.0] Show series, fields and tags with over 10k series in DB are truncated (unexpected behaviour) Feb 8, 2017
@joelio
Copy link

joelio commented Feb 8, 2017

@pkittenis
Copy link
Author

Yes, though max-row-limit did not apply to SHOW queries before 1.2.

@joelio
Copy link

joelio commented Feb 8, 2017

👍

@jwilder
Copy link
Contributor

jwilder commented Feb 8, 2017

max-row-limit has a default of 10000 which was added in #6126 back when 0.12 was released. It looks like it was not working properly and was fixed in 1.2 via #7368. The workaround currently is to set max-row-limit = 0 in your config.

@pkittenis
Copy link
Author

Thanks @jwilder, sounds like clients will need to handle this behaviour.

@pkittenis
Copy link
Author

Closing as not a bug

@geethanjalieswaran
Copy link

@jwilder Even after setting max-row-limit = 0 in my config, my results are truncated to 10000. Expected or a bug indeed? This works as (my) expected in version 1.1 (i.e results not truncated).

@jwilder
Copy link
Contributor

jwilder commented Feb 15, 2017

@geethanjalieswaran you have under the [http] sections?

[http]
max-row-limit = 0

@geethanjalieswaran
Copy link

@jwilder Sorry for the false alarm! It was not under [http] section.
Confirming that below is working as expected in version 1.2.

[http]
max-row-limit = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants