Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting default namespace while executing kubectl commands #176

Closed
mstrYoda opened this issue Sep 13, 2019 · 0 comments · Fixed by #188
Closed

Setting default namespace while executing kubectl commands #176

mstrYoda opened this issue Sep 13, 2019 · 0 comments · Fixed by #188
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@mstrYoda
Copy link

Is your feature request related to a problem? Please describe.
I could not see any configuration about default namespace to work with kubectl commands. So every time passing ns parameter is so verbose.

Describe the solution you'd like
It would be great to add namespace parameter to settings field in config.

Describe alternatives you've considered

Additional context
@mstrYoda mstrYoda added the enhancement New feature or request label Sep 13, 2019
@PrasadG193 PrasadG193 added hacktoberfest help wanted Extra attention is needed labels Oct 6, 2019
@codenio codenio mentioned this issue Oct 8, 2019
Merged
@mergify mergify bot closed this as completed in #188 May 1, 2020
mergify bot pushed a commit that referenced this issue May 1, 2020
@codenio
Configure default namespace for kubectl cmds through config
ebd2c93 
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
 - Feature Pull Request

##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
This Commit,
- Adds `kubectl.Enabled`, `Kubectl.DefaultNamespace` to `Config.Settings` to configure default namespace, under which all  botkube kubectl commands will be executed by default.
- changes `Settings.RestrictAccess` into `Settings. Kubectl.RestrictAccess` 
- updates all config.yaml files
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->

<!--- Please list dependencies added with your change also -->

Fixes #176

**Preview**:

```yaml
settings:
  # Kubectl executor configs
  kubectl:
    # Set true to enable kubectl commands execution
    enabled: false
    # set Namespace to execute botkube kubectl commands by default
    defaultNamespace: default
    # Set true to enable commands execution from configured channel only
    restrictAccess: false
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure default namespace for kubectl cmds through config codenio/botkube
2 participants
@PrasadG193 @mstrYoda