You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mitchellmaler
changed the title
[BUG] Helm Chart clusterrole invalid if PSP enabled
[BUG] Helm Chart clusterrole invalid if PSP and rbac are both enabled
Aug 14, 2020
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug fix Pull Request
##### SUMMARY
<!--- Describe the change, including rationale and design decisions -->
Correctly indent RBAC rules. It was previously throwing an error when enabling both psp and rbac at the value level.
<!---
If you are fixing an existing issue, please include "Fixes #nnn" in your
PR comment; and describe briefly what the change does.
-->
<!--- Please list dependencies added with your change also -->
Fixes#325
Describe the bug
If both RBAC and PSP are enabled the two rules added to the clusterrole are not indented the same.
https://github.com/infracloudio/botkube/blob/develop/helm/botkube/templates/clusterrole.yaml#L11
To Reproduce
Steps to reproduce the behavior:
Install chart (or template) with both rbac and psp enabled.
Expected behavior
Cluster role is set correctly.
Screenshots
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: