Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make target for building BotKube binary #90

Closed
bhavin192 opened this issue May 13, 2019 · 0 comments · Fixed by #100
Closed

Make target for building BotKube binary #90

bhavin192 opened this issue May 13, 2019 · 0 comments · Fixed by #100
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bhavin192
Copy link
Contributor

Should add a rule Makefile for this? As of now, make build builds docker image for Botkube. Instead of that we can have make build- to build binary and make image - to build docker image.

#79 (comment)

We can have something like make container-image as target to build container image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New make target container-image to build docker image vinayakshnd/botkube
1 participant
@bhavin192