Added restrictAccess flag to enable/disable behavior of botkube. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Dec 30, 2019
… flag will control user's access to botkube via configured channel. If set to true, it will allow user to talk to botkube only through configured channel. In other case, botkube will be accessible from all channels. Signed-off-by: Mahendra Bagul <[email protected]> Fixed #238 (comment) issue. Removed msg and re-added the check required for not responding to non-kubectl commands Signed-off-by: Mahendra Bagul <[email protected]> Fixed a test case Signed-off-by: Mahendra Bagul <[email protected]> Fixed #238 (comment) issue. Removed msg and re-added the check required for not responding to non-kubectl commands Signed-off-by: Mahendra Bagul <[email protected]> Placed the condition at right place. Signed-off-by: Mahendra Bagul <[email protected]>
PrasadG193
approved these changes
Jan 1, 2020
|
Merged! Thanks @mahendrabagul for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag will control user's access to botkube via configured channel. If set to true, it will allow user to talk to botkube only through configured channel. In other case, botkube will be accessible from all channels.
Signed-off-by: Mahendra Bagul [email protected]
ISSUE TYPE
SUMMARY
Fix for #235