Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow kubectl commands without namespace and without cluster-name #301

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Allow kubectl commands without namespace and without cluster-name #301

merged 1 commit into from
Jun 30, 2020

Conversation

gmkumar2005
Copy link
Contributor 

##### ISSUE TYPE
 - Bug fix Pull Request

##### SUMMARY
Default executor is expecting more than 2 arguments.
Fixed number of arguments needed to 1.

Fixes #300

@gmkumar2005
Allow kubectl commands wihtout namespace and without cluster-name
ba4ff0a 
    ##### ISSUE TYPE
    BUG

    ##### SUMMARY
    Default executor is expecting more than 2 arguments.
Fixed number of arguments needed to 1.

Fixes kubeshop#300
@PrasadG193
Copy link
Collaborator

Thanks a lot for fixing this @gmkumar2005 🙏

@mergify mergify bot merged commit cc3fc6d into kubeshop:develop Jun 30, 2020
@gmkumar2005 gmkumar2005 deleted the executorissue branch June 30, 2020 13:41
@sanketsudake sanketsudake changed the title Allow kubectl commands wihtout namespace and without cluster-name Allow kubectl commands without namespace and without cluster-name Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrasadG193 PrasadG193 PrasadG193 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executor fails to run when cluster-name is ignored [BUG]
2 participants
@gmkumar2005 @PrasadG193