Update resource in deployment manifests with G/V/R format #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prasad Ghangal <[email protected]>
|
In G/V/R format its good to have plural resource(eg: pod -> v1/pods) |
|
@PrasadG193 I see a lot of indentation changes, are we using some linting tool for this? |
rahulchheda
reviewed
Sep 7, 2020
deploy-all-in-one.yaml
Outdated
| - create | ||
| - delete | ||
| - error | ||
| - name: rbac.authorization.k8s.io/v1/clusterrolebindings |
There was a problem hiding this comment.
Suggested change
| - name: rbac.authorization.k8s.io/v1/clusterrolebindings | |
| - name: rbac.authorization.k8s.io/v1/clusterroles |
deploy-all-in-one-tls.yaml
Outdated
| - create | ||
| - delete | ||
| - error | ||
| - name: rbac.authorization.k8s.io/v1/clusterrolebindings |
There was a problem hiding this comment.
Suggested change
| - name: rbac.authorization.k8s.io/v1/clusterrolebindings | |
| - name: rbac.authorization.k8s.io/v1/clusterroles |
|
@rahulchheda Yes, we run helm lint. Basically for lists |
Signed-off-by: Prasad Ghangal <[email protected]>
sanketsudake
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prasad Ghangal [email protected]
ISSUE TYPE
SUMMARY
Update resource in deployment manifests with G/V/R format
Fixes #331