Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding option to create and destroy kind clusters #365

Merged
merged 17 commits into from
Oct 5, 2020

Conversation

Abhishek627
Copy link
Contributor

ISSUE TYPE
  • Feature Pull Request
SUMMARY

Created a script to create and destroy KIND clusters which can be used to execute test and CD jobs. Added make targets for those and default make help.

Fixes #320

@Abhishek627
Copy link
Contributor Author

@PrasadG193 Let me know this looks good or you had something else in mind.

hack/kind-cluster.sh Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@Abhishek627 Abhishek627 requested a review from PrasadG193 October 1, 2020 08:22
Makefile Outdated Show resolved Hide resolved
hack/kind-cluster.sh Outdated Show resolved Hide resolved
hack/kind-cluster.sh Outdated Show resolved Hide resolved
@Abhishek627 Abhishek627 requested a review from PrasadG193 October 2, 2020 08:58
hack/kind-cluster.sh Outdated Show resolved Hide resolved
@Abhishek627 Abhishek627 requested a review from PrasadG193 October 3, 2020 10:35
hack/kind-cluster.sh Outdated Show resolved Hide resolved
@Abhishek627 Abhishek627 requested a review from PrasadG193 October 3, 2020 12:35
@rahulchheda
Copy link

@Abhishek627 E2E tests seems to fail, could you resolve them. Here is the gist for it.

--- FAIL: TestRun/update (4.00s)
        --- FAIL: TestRun/update/update_resource (4.00s)
            --- FAIL: TestRun/update/update_resource/update_resource_when_IncludeDiff_is_set_to_false (2.00s)
                update.go:135: 
                    	Error Trace:	update.go:135
                    	Error:      	Not equal: 
                    	            	expected: notify.EventStatus{Type:"update", Level:"warn", Reason:"", Error:"", Messages:[]string(nil)}
                    	            	actual  : notify.EventStatus{Type:"create", Level:"info", Reason:"", Error:"", Messages:[]string(nil)}
                    	            	
                    	            	Diff:
                    	            	--- Expected
                    	            	+++ Actual
                    	            	@@ -1,4 +1,4 @@
                    	            	 (notify.EventStatus) {
                    	            	- Type: (config.EventType) (len=6) update,
                    	            	- Level: (config.Level) (len=4) "warn",
                    	            	+ Type: (config.EventType) (len=6) create,
                    	            	+ Level: (config.Level) (len=4) "info",
                    	            	  Reason: (string) "",
                    	Test:       	TestRun/update/update_resource/update_resource_when_IncludeDiff_is_set_to_false
                update.go:136: 
                    	Error Trace:	update.go:136
                    	Error:      	Not equal: 
                    	            	expected: "Pod *test/test-pod-update-diff-false* has been updated in *test-cluster-1* cluster\n"
                    	            	actual  : "Pod *test/test-pod-update-diff-false* has been created in *test-cluster-1* cluster\n```\nRecommendations:\n- pod 'test-pod-update-diff-false' creation without labels should be avoided.\n```"
                    	            	
                    	            	Diff:
                    	            	--- Expected
                    	            	+++ Actual
                    	            	@@ -1,2 +1,5 @@
                    	            	-Pod *test/test-pod-update-diff-false* has been updated in *test-cluster-1* cluster
                    	            	-
                    	            	+Pod *test/test-pod-update-diff-false* has been created in *test-cluster-1* cluster
                    	            	+```
                    	            	+Recommendations:
                    	            	+- pod 'test-pod-update-diff-false' creation without labels should be avoided.
                    	            	+```
                    	Test:       	TestRun/update/update_resource/update_resource_when_IncludeDiff_is_set_to_false
            --- PASS: TestRun/update/update_resource/create_and_update_pod_in_configured_namespace (2.00s)
        --- PASS: TestRun/update/skip_update_event (0.00s)
            --- PASS: TestRun/update/skip_update_event/skip_update_event_for_namespaces_not_configured (0.00s)
            --- PASS: TestRun/update/skip_update_event/skip_update_event_for_resources_not_added (0.00s)
    --- PASS: TestRun/delete (0.00s)
        --- PASS: TestRun/delete/delete_resource (0.00s)
            --- PASS: TestRun/delete/delete_resource/skip_delete_event_for_resources_not_configured (0.00s)
FAIL
FAIL	github.com/infracloudio/botkube/test/e2e	30.060s
FAIL
Error: Makefile:34: recipe for target 'test' failed
make: *** [test] Error 1
Error: Process completed with exit code 2.

@PrasadG193
Copy link
Collaborator

@rahulchheda e2e test failure issue is unrelated. We are tracking that with #384

@mergify mergify bot merged commit af6a000 into kubeshop:develop Oct 5, 2020
@chetanpdeshmukh
Copy link

Hello @Abhishek627 ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add script to create and destroy KIND cluster
4 participants