Added check slack channel in config, when get message

[gimmetm]

For cluster-channel pair use

[PrasadG193]

Hey @gimmetm,
Thanks for the PR 🙂

Looks like hack/verify-gofmt.sh is failing.

$ hack/verify-gofmt.sh
diff -u ./pkg/slack/slack.go.orig ./pkg/slack/slack.go
--- ./pkg/slack/slack.go.orig	2019-02-20 05:50:34.363532422 +0000
+++ ./pkg/slack/slack.go	2019-02-20 05:50:34.363532422 +0000
@@ -75,7 +75,7 @@
 				}
 				// if checkChannel is true
 				// Serve only if current channel is in config
-				if b.CheckChannel && (b.ChannelName != channel.Name){
+				if b.CheckChannel && (b.ChannelName != channel.Name) {
 					continue
 				}
 
@@ -90,7 +90,7 @@
 					}
 					// if checkChannel is true
 					// Serve only if current group is in config
-					if b.CheckChannel && (b.ChannelName != group.Name){
+					if b.CheckChannel && (b.ChannelName != group.Name) {
 						continue
 					}
 				}
Run ./hack/update-gofmt.sh
The command "hack/verify-gofmt.sh" failed and exited with 1 during .

Running hack/update-gofmt.sh should fix that.

[PrasadG193]

  # Channels configuration
  communications:
    slack:
      channel: 'SLACK_CHANNEL'

@gimmetm, the communication.slack.channel in the configuration is only for restricting push notifications from BotKube. So as per the design, we should be able to execute kubectl commands from any channel, group (shared chat) or even from Direct Message to BotKube.
I am trying to understand what use case you are trying to solve?

[PrasadG193]

BTW we are disabling notifier commands execution outside the channel as a part of separate issue

[gimmetm]

in case of multi cluster and each channel for each cluster, excute command message shows other channel(cluster) info too. I don’t want show other cluster command result on the channel. thank you. 2019년 2월 20일 (수) 19:48, Prasad Ghangal <[email protected]>님이 작성:

…

BTW we are disabling notifier commands execution outside the channel as a part of separate issue — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJZhb77Wvp11xYGqBPtU1XCo78OF6-Q2ks5vPSgQgaJpZM4bEdaT> .

[PrasadG193]

@gimmetm can you please remove this check? We should be able to execute BotKube commands from group chats.

[gimmetm]

@PrasadG193 This check is for private channel. (https://api.slack.com/methods/groups.info)
group chat info might be in conversation.info or else.

[PrasadG193]

Also, please squash your commits into one

[PrasadG193]

@gimmetm actually, client.GroupInfo() (https://godoc.org/github.com/nlopes/slack#Client.GetGroupInfo) returns true for a private channel as well as group chat. We need to find a better way to differentiate between them.

[gimmetm]

@PrasadG193 I replaced GetChannelInfo&GetGroupInfo -> GetConversationInfo,
and checked (IsChannel, IsPrivate)
Please review it.

[PrasadG193]

Nice! But still, group BotKube is not responding in group chat. Can you please test it on your setup?

[PrasadG193]

@gimmetm actually, client.GroupInfo() (https://godoc.org/github.com/nlopes/slack#Client.GetGroupInfo) returns true for a private channel as well as group chat. We need to find a better way to differentiate between them.

Let's track this as a separate issue