Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track only valid requests and responses #404

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

codenio
Copy link
Contributor

@codenio codenio commented Oct 6, 2020

This Commit,

  • Adds Debug logs to slack and matter most bot to log the valid request sent to the bot and the corresponding responses generated.
  • removes the logging to all events, to avoid capture of sensitive data.
ISSUE TYPE
  • Feature Pull Request
  • Bug fix Pull Request
SUMMARY

Created this as a separate PR, as it not connected with Discord Integration.
added these features there as well.

This Commit, 
- Adds Debug logs to slack and mattermost bot to log the valid request sent to the bot and the corresponding responses generated.
- removes the logging to all events, to avoid capture of sensitive data.
@codenio codenio mentioned this pull request Oct 6, 2020
@mergify mergify bot merged commit d051509 into kubeshop:develop Oct 6, 2020
@chetanpdeshmukh
Copy link

Hello @codenio ,
Thanks again for the PR!

Thank you for contributing to BotKube. Could you please fill out this form, so we can send the well deserved awesome swags 🙂

Team BotKube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants