Rename kubeops to botkube #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanketsudake
suggested changes
Jan 3, 2019
README.md
Outdated
|
|
||
| ## Configuration | ||
| Kubeops reads configurations from `kubeopsconfig.yaml` file placed at `KUBEOPS_CONFIG_PATH` | ||
| Kubeops reads configurations from `botkubeconfig.yaml` file placed at `KUBEOPS_CONFIG_PATH` |
There was a problem hiding this comment.
Rename file to config.yaml
There was a problem hiding this comment.
Add link to file in README
sanketsudake
reviewed
Jan 3, 2019
| @@ -3,10 +3,10 @@ package main | |||
| import ( | |||
There was a problem hiding this comment.
Rename file folder to botkube. As cmd is for botkube
PrasadG193
commented
Jan 3, 2019
pkg/execute/executor.go
Outdated
| @@ -36,7 +36,7 @@ var kubectlBinary = "/usr/local/bin/kubectl" | |||
| const ( | |||
| notifierStopMsg = "Brace yourselves, notifications are coming." | |||
| notifierStartMsg = "Sure! I won't send you notifications anymore." | |||
There was a problem hiding this comment.
wrong start and stop message
PrasadG193
force-pushed
the
rename-to-botkube
branch
from
563ba2b to
2a09378
Compare
PrasadG193
force-pushed
the
rename-to-botkube
branch
from
2a09378 to
f6a389a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4