Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPv6 #62

Merged
merged 4 commits into from
Jul 27, 2024
Merged

Add IPv6 #62

merged 4 commits into from
Jul 27, 2024

Conversation

LikDan
Copy link
Contributor

@LikDan LikDan commented May 29, 2024

Rewrite method that check host to accept IPv6 format

@maximevw
Copy link
Collaborator

maximevw commented May 29, 2024 •
edited
Loading

@LikDan

Thanks a lot for your PR. Could you please add additional test cases to check that the parsing of multiple hosts using IPv6 or a mix of IPv6, IPv4, hostname are supported?
For example:
[0000:1111:2222:3333:aaaa:ffff]--[0123::456b:789c:ffff]:9042
or [0000:1111:2222:3333:aaaa:ffff]--127.0.0.1--cassandra-host:9042

@maximevw maximevw merged commit 38020f2 into ing-bank:release/next Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LikDan @maximevw