Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change verbosity level #152

Open
sbrugman opened this issue Oct 21, 2021 · 4 comments
Open

Change verbosity level #152

sbrugman opened this issue Oct 21, 2021 · 4 comments
Labels
API Programmable user interface enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sbrugman
Copy link
Collaborator

popmon by default provides logging and progress bar (tqdm) output while computing the report. There currently is no user-friendly way to change the verbosity level altogether.

@sbrugman sbrugman added the enhancement New feature or request label Oct 21, 2021
@sbrugman sbrugman added API Programmable user interface good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2021
@rishabsinghh
Copy link

Hey, i would like to start working on this issue. Can you please guide me?

@sbrugman
Copy link
Collaborator Author

sbrugman commented Jun 13, 2023

@rishabsinghh Welcome!

The way logging is performed in popmon is that each Module has a logger property.
Modules will call self.logger.info, self.logger.warn etc.

See for example:

In addition, the tqdm progress bar is used, e.g.

This issue was intended to re-evaluate the usefulness of each of the logging statements and their level (is it debug information? Then it should be self.logger.debug).

Then, the user should be able to control the level of output to receive (either via the logging config, or via popmon's Settings)

Does this help you forward?

ps. also open to use alive-progress instead of tqdm

@rishabsinghh
Copy link

Hey @sbrugman . This helps, i will ask you incase of any queries, thanks!

@rishabsinghh
Copy link

Hey @sbrugman . Few Thoughts! Please correct me if i am going in the wrong direction

  1. Verbosity can be defined as an input variables with numbers indicating the level of logging user needs. We may define this at the time we generate report settings.

Some thing like this!

image

And for progress bar similarly we can have another input variable called "show_progress_bar" which would be boolean. True and False.

Does this make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Programmable user interface enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants