Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: cannot patch youtube v19.44.39 using CLI since revanced-patches v5.2.2 #2730

Closed
7 tasks done
twu2 opened this issue Jan 22, 2025 · 13 comments
Closed
7 tasks done
Labels
Bug report Something isn't working

Comments

@twu2
Copy link

twu2 commented Jan 22, 2025

Type

Error while patching

Tools used

CLI

Application

Youtube v19.44.39

Bug description

app.revanced.patcher.patch.PatchException: The patch "Settings for YouTube" depends on "BytecodePatch (cairoFragmentPatch)", which raised an exception:
got above error for almost all patch for youtube v19.44.39 using cli v5.0.1. but work fine for v19.16.39.

this issue happen for patches v5.2.2 and v5.3.1.
same patch command work fine for patches v5.2.1 with v19.44.39.

Error logs

INFO: Loading patches
INFO: Deleting existing temporary files directory
INFO: Decoding app manifest
INFO: "Change version code" disabled
INFO: "Enable debug logging" disabled manually
INFO: "GmsCore support" disabled manually
INFO: "Return YouTube Dislike" disabled manually
INFO: "Hide Shorts dimming" disabled
INFO: "Custom header for YouTube" disabled manually
INFO: "Force hide player buttons background" disabled
INFO: "Hide shortcuts" disabled
INFO: "MaterialYou" disabled
INFO: "Enable debug logging" disabled manually
INFO: "GmsCore support" disabled manually
INFO: "Return YouTube Dislike" disabled manually
INFO: "Return YouTube Username" disabled
INFO: Setting patch options
INFO: Deleting existing temporary files directory
INFO: Decoding resources
INFO: Initializing lookup maps
INFO: Executing patches
SEVERE: "Alternative thumbnails" failed:
app.revanced.patcher.patch.PatchException: The patch "Alternative thumbnails" depends on "Settings for YouTube", which raised an exception:
app.revanced.patcher.patch.PatchException: The patch "Settings for YouTube" depends on "BytecodePatch (cairoFragmentPatch)", which raised an exception:
app.revanced.patcher.patch.PatchException: Could not find instruction index
        at app.revanced.util.BytecodeUtilsKt.indexOfFirstInstructionOrThrow(BytecodeUtils.kt:408)
        at app.revanced.patches.youtube.utils.fix.cairo.CairoFragmentPatchKt.cairoFragmentPatch$lambda$14$lambda$13(CairoFragmentPatch.kt:101)
        at app.revanced.patcher.patch.Patch.execute(Patch.kt:71)
        at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(Patch.kt:166)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:84)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
        at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:75)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
        at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:75)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
        at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

SEVERE: "Ambient mode control" failed:

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@twu2 twu2 added the Bug report Something isn't working label Jan 22, 2025
@inotia00
Copy link
Owner

Please add the OS version and Java version you tried to patch.

@wb59
Copy link

wb59 commented Jan 22, 2025

same issue.
my build command in Windows 10:

java -jar revanced-cli-5.0.1-all.jar patch -p patches-5.3.1.rvp -o youtube_ext_v19.44.39.apk --purge  com.google.android.youtube_v19.44.39.apk

My current java version. I tried to update jdk from JDK 21 but it's no hope

openjdk version "23.0.2" 2025-01-21
OpenJDK Runtime Environment (build 23.0.2+7-58)
OpenJDK 64-Bit Server VM (build 23.0.2+7-58, mixed mode, sharing)

Exception that i got:

INFO: Loading patches
INFO: Decoding app manifest
INFO: "Change version code" disabled
INFO: "Hide Shorts dimming" disabled
INFO: "Custom header for YouTube" disabled
INFO: "Force hide player buttons background" disabled
INFO: "Hide shortcuts" disabled
INFO: "MaterialYou" disabled
INFO: "Return YouTube Username" disabled
INFO: Setting patch options
INFO: Deleting existing temporary files directory
INFO: Decoding resources
INFO: Initializing lookup maps
INFO: Executing patches
SEVERE: "Alternative thumbnails" failed:
app.revanced.patcher.patch.PatchException: The patch "Alternative thumbnails" depends on "Settings for YouTube", which raised an exception:
app.revanced.patcher.patch.PatchException: The patch "Settings for YouTube" depends on "BytecodePatch (cairoFragmentPatch)", which raised an exception:
app.revanced.patcher.patch.PatchException: Could not find instruction index
        at app.revanced.util.BytecodeUtilsKt.indexOfFirstInstructionOrThrow(BytecodeUtils.kt:408)
        at app.revanced.patches.youtube.utils.fix.cairo.CairoFragmentPatchKt.cairoFragmentPatch$lambda$14$lambda$13(CairoFragmentPatch.kt:101)
        at app.revanced.patcher.patch.Patch.execute(Patch.kt:71)
        at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(Patch.kt:166)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:84)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
        at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
        at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
        at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
        at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
        at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
        at picocli.CommandLine.execute(CommandLine.java:2174)
        at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

Same apk file, same cli, same rvp, same command is working when i'm try with Ubuntu 20.0.4

@inotia00
Copy link
Owner

inotia00 commented Jan 22, 2025

I always test with cli before releasing a patch.

Here is the environment I tested on:

Windows 10 (x86_64)
Zulu JDK 17.0.13

The documentation also recommends using Zulu JDK 17.

(All tools including Patcher, Library, Manager, Cli are compiled with Java 17)

It doesn't seem to be related, but at least I tested it in this environment.

@twu2
Copy link
Author

twu2 commented Jan 22, 2025

Debian 12 (x86_64)
Open JDK 17.0.13

openjdk version "17.0.13" 2024-10-15
OpenJDK Runtime Environment (build 17.0.13+11-Debian-2deb12u1)
OpenJDK 64-Bit Server VM (build 17.0.13+11-Debian-2deb12u1, mixed mode, sharing)

@belinux
Copy link

belinux commented Jan 22, 2025

Same here,

  • Command:
    java -jar revanced-cli-5.0.1-all.jar patch -p patches-5.3.1.rvp com.google.android.youtube-19.44.39-all.apk

  • Exception:

INFO: Executing patches 
SEVERE: "Alternative thumbnails" failed:
app.revanced.patcher.patch.PatchException: The patch "Alternative thumbnails" depends on "Settings for YouTube", which raised an exception:
app.revanced.patcher.patch.PatchException: The patch "Settings for YouTube" depends on "BytecodePatch (cairoFragmentPatch)", which raised an exception:
app.revanced.patcher.patch.PatchException: Could not find instruction index
	at app.revanced.util.BytecodeUtilsKt.indexOfFirstInstructionOrThrow(BytecodeUtils.kt:408)
	at app.revanced.patches.youtube.utils.fix.cairo.CairoFragmentPatchKt.cairoFragmentPatch$lambda$14$lambda$13(CairoFragmentPatch.kt:101)
	at app.revanced.patcher.patch.Patch.execute(Patch.kt:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(Patch.kt:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
	at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
	at picocli.CommandLine.execute(CommandLine.java:2174)
	at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:75)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:72)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
	at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
	at picocli.CommandLine.execute(CommandLine.java:2174)
	at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)

	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(Patcher.kt:75)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(Patcher.kt:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at app.revanced.patcher.Patcher$invoke$1.invoke(Patcher.kt)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:226)
	at app.revanced.cli.command.PatchCommand$run$1$3.invokeSuspend(PatchCommand.kt:356)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:355)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2030)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2465)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2457)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2419)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2277)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2421)
	at picocli.CommandLine.execute(CommandLine.java:2174)
	at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
  • OS :
Archlinux x64
  • Java:
openjdk 23.0.1 2024-09-17
OpenJDK Runtime Environment (build 23.0.1)
OpenJDK 64-Bit Server VM (build 23.0.1, mixed mode, sharing)

@twu2
Copy link
Author

twu2 commented Jan 23, 2025

try to using zulu jdk (17, 21, 23) from azul under Debian 12. still got same error for patches 5.2.2 and 5.3.1 (5.2.1 work fine).
also try to patch it under Windows 10 with zulu 17.0.13, same error (5.2.1 work fine).

@theo546
Copy link

theo546 commented Jan 23, 2025

I'd also like to include the failure of patching using the cli since patches version 5.2.2 and 5.3.1.

The OS version this was run on is Debian 12.

This problem only arise when patching YouTube 19.44.39.
YouTube Music doesn't seem to be affected by this issue.

Java version:

java -version
openjdk version "17.0.14" 2025-01-21 LTS
OpenJDK Runtime Environment Zulu17.56+15-CA (build 17.0.14+7-LTS)
OpenJDK 64-Bit Server VM Zulu17.56+15-CA (build 17.0.14+7-LTS, mixed mode, sharing)

Build command:

java -jar /tmp/inotia00/revanced-cli.jar patch --temporary-files-path /tmp/cli -p /tmp/inotia00/revanced-patches.rvp /original_apks/com.google.android.youtube/com.google.android.youtube_19.44.39.apk --out /tmp/com.google.android.youtube_19.44.39_patched.apk_before_processing --purge --enable 'Custom header for YouTube' --enable 'Visual preferences icons' --enable 'Change version code' -OversionCode='27149959' -OchangeVersionCode=true --enable 'Theme' -OdarkThemeBackgroundColor='#FF290025' -OlightThemeBackgroundColor='#FFFCCFF3'

I've dropped the logs as a file, they are too big to be sent as a text on GitHub.

logs.txt

@inotia00
Copy link
Owner

inotia00 commented Jan 23, 2025

No need to attach any more logs

I found which class and which instruction throws exception

But I don't know why exception is thrown

(There is no issue in source code)

So I see this as an issue that can only be reproduced in a specific environment

Since issue is not reproduced on my side, it takes a lot of time

@wb59
Copy link

wb59 commented Jan 23, 2025

No need to attach any more logs

I found which class and which instruction throws exception

But I don't know why exception is thrown

(There is no issue in source code)

So I see this as an issue that can only be reproduced in a specific environment

Since issue is not reproduced on my side, it takes a lot of time

Would you like to build a version, log everything you need, and send it to me so I can run it in my environment?

@Ale2077

This comment has been minimized.

@Unr3aL

This comment has been minimized.

@0xD3N1Z

This comment has been minimized.

Repository owner locked as too heated and limited conversation to collaborators Jan 29, 2025
@inotia00
Copy link
Owner

Fixed in revanced-patches-5.4.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants