Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): (sponsorblock) better skipped time format #279

Closed
3 tasks done
NBruderman opened this issue Feb 19, 2023 · 3 comments
Closed
3 tasks done

feat(patch): (sponsorblock) better skipped time format #279

NBruderman opened this issue Feb 19, 2023 · 3 comments
Labels
Feature request Requesting a new feature

Comments

@NBruderman
Copy link

Type

Cosmetic

Application

ReVanced Extended v18.06.35

Bug description

In sponsor block, the time you saved have missing spaces in the time shown between the numbers and the text (example in the screenshot below)

Steps to reproduce

Enter into the sponsorblock tab, go to the bottom, and you'll see it

Relevant log output

not relevant

Screenshots or videos

Inkedתמונה של WhatsApp‏ 2023-02-19 בשעה 10 30 14

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@NBruderman NBruderman added the Bug report Something isn't working label Feb 19, 2023
@inotia00
Copy link
Owner

'47 minutes 11 seconds' instead of '47minutes 11seconds'?

@NBruderman
Copy link
Author

yep, exactly. although personally I liked the old format (47 min, 11 sec) better.

@inotia00 inotia00 added Feature request Requesting a new feature and removed Bug report Something isn't working labels Feb 19, 2023
@inotia00 inotia00 changed the title bug: Sponsor block: time you saved have missing spaces between numbers and words feat(patch): (sponsorblock) better skipped time format Feb 19, 2023
@inotia00
Copy link
Owner

inotia00 commented Feb 21, 2023

reflected in revanced-patches-v2.162.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature
Projects
None yet
Development

No branches or pull requests

2 participants