Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hide-get-premium patch fails when not including other patches #386

Closed
3 tasks done
hoang-himself opened this issue Mar 2, 2023 · 10 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@hoang-himself
Copy link

Type

Error while patching

Application

YouTube Music v5.44.54, v5.45.52, v5.45.53, v5.46.52

Bug description

While patching

Steps to reproduce

Step 1: include hide-get-premium and patch

Relevant log output

Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
An error occurred! Aborting
Error:
java.lang.reflect.InvocationTargetException
	at java.lang.reflect.Constructor.newInstance0(Native Method)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:318)
	at app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:37)
	at app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:355)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:129)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$20(MainActivity.kt:327)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$VzOqgSVOualTn6WBlAKw3muxHF8(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda13.run(Unknown Source:24)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: kotlin.UninitializedPropertyAccessException: lateinit property resourceMappings has not been initialized
	at app.revanced.patches.shared.patch.mapping.ResourceMappingPatch$Companion.getResourceMappings$revanced_patches(ResourceMappingPatch.kt:20)
	at app.revanced.patches.music.layout.premium.patch.HideGetPremiumPatch.<init>(HideGetPremiumPatch.kt:40)
	... 11 more

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

Samsung Galaxy A71, OneUI 5.0, Android 13, arm64-v8a

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@hoang-himself hoang-himself added the Bug report Something isn't working label Mar 2, 2023
@hoang-himself hoang-himself changed the title bug: hide-get-premium with YT Music bug: cannot apply hide-get-premium with YT Music Mar 2, 2023
@ILoveOpenSourceApplications

Are you a rooted user? If not please include the Music-MicroG-Support and try repatching again.

@hoang-himself
Copy link
Author

I am not rooted. I tried applying both Music MicroG Support and Hide Get Premium and I still encounter the bug, same log output.

@inotia00
Copy link
Owner

inotia00 commented Mar 2, 2023

ah, I missed this just before the final build
This will be fixed in the next release

@inotia00 inotia00 changed the title bug: cannot apply hide-get-premium with YT Music bug: hide-get-premium patch fails when not including other patches Mar 2, 2023
@ILoveOpenSourceApplications

ah, I missed this just before the final build This will be fixed in the next release

Yes, it seems hide-get-premium requires some other patches to be included with it or else it keeps failing.

@ghost

This comment was marked as off-topic.

@ILoveOpenSourceApplications

This comment was marked as off-topic.

@inotia00
Copy link
Owner

inotia00 commented Mar 2, 2023

@DrimTim2020 You don't seem to know what this patch means

The hide-get-premium patch is a patch that removes this banner.

music

And, when all patches are included, this patch works just fine.

If this patch doesn't work as intended, please open a new issue with the form met.

@ghost

This comment was marked as off-topic.

@inotia00
Copy link
Owner

inotia00 commented Mar 2, 2023

This is a place to report issues, not a place for discussion.
please stop the dispute

Also, please refrain from actions that may cause a dispute.

Repository owner locked as too heated and limited conversation to collaborators Mar 2, 2023
@inotia00
Copy link
Owner

inotia00 commented Mar 3, 2023

fixed in revanced-patches-v2.164.15

@inotia00 inotia00 closed this as completed Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants