Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: like/dislike button container in "Right to Left Languages" #468

Closed
3 tasks done
blacktornadog7 opened this issue Mar 13, 2023 · 5 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@blacktornadog7
Copy link

Type

Cosmetic

Application

YouTube 18.08.39

Bug description

In "Right to Left Languages" (like Arabic and Hebrew) the like/dislike counter doesn't show up properly (screenshot below).
And sometimes when liking a video the dislike counter disappears (this mostly happens when the dislikes are 1-2 digit numbers).

Steps to reproduce

  1. change Youtube's display language from the phone settings (requires android 13) or change the whole phone display language to a right to left language.
  2. like a video

Relevant log output

no logs

Screenshots or videos

Screenshot_20230313_163937_ReVanced Extended

Screen.recording_20230313_163937_ReVanced.Extended.mp4

Solution

🤷🤷🤷

Additional context

No response

Device Environment

Android 13 (One UI 5)

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@blacktornadog7 blacktornadog7 added the Bug report Something isn't working label Mar 13, 2023
@blacktornadog7 blacktornadog7 changed the title bug: <like/dislike button container in "Right to Left Languages"> bug: like/dislike button container in "Right to Left Languages" Mar 14, 2023
@inotia00
Copy link
Owner

inotia00 commented Mar 17, 2023

fixed by ReVanced Team
(reflected in revanced-patches-v2.166.1)

@inotia00
Copy link
Owner

nah.. this issue is still valid, so I'll reopen it.

@inotia00 inotia00 reopened this Mar 20, 2023
@inotia00
Copy link
Owner

ReVanced
fixed in revanced-patches-v2.166.10

@blacktornadog7
Copy link
Author

blacktornadog7 commented Mar 22, 2023

when likes are below 1000, dislikes still disappear as in the clip I posted before, even when youtube's display language is set to english i.e non RTL layout.

@inotia00
Copy link
Owner

This is an issue that has been registered before.

After about 3 seconds, the dislike count will be displayed again

This issue cannot be fixed due to limitations in the implementation of return-youtube-dislike.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants