Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: default-video-speed patch fails #470

Closed
3 tasks done
colbyashilewis11 opened this issue Mar 13, 2023 · 1 comment
Closed
3 tasks done

bug: default-video-speed patch fails #470

colbyashilewis11 opened this issue Mar 13, 2023 · 1 comment
Labels
Bug report Something isn't working

Comments

@colbyashilewis11
Copy link

Type

Error while patching

Application

YouTube v18.06.41, v18.07.35 and v18.08.39

Bug description

default-video-speed patch fails

Steps to reproduce

Step 1. include default-video-speed and patch.

Relevant log output

INFO: Reading dex files 
INFO: Loading resource table... 
INFO: Decoding AndroidManifest.xml only, because resources are not needed 
INFO: Loading resource table from file: revanced-cache/1.apk 
INFO: Skipping custom-branding-icon-afn-blue: Excluded by default 
INFO: Skipping custom-branding-icon-afn-red: Excluded by default 
INFO: Skipping custom-branding-icon-mmt: Excluded by default 
INFO: Skipping force-premium-heading: Excluded by default 
INFO: Skipping materialyou: Excluded by default 
INFO: Merging inotia00-integrations-v0.99.24.apk 
INFO: Loading resource table... 
INFO: Deleting existing resource cache directory 
INFO: Decoding resources 
INFO: Decoding AndroidManifest.xml with resources... 
INFO: Loading resource table from file: revanced-cache/1.apk 
INFO: Regular manifest package... 
INFO: Decoding file-resources... 
INFO: Decoding values */* XMLs... 
INFO: client-spoof succeeded 
INFO: custom-branding-icon-revancify succeeded 
INFO: custom-branding-name succeeded 
INFO: custom-seekbar-color succeeded 
INFO: custom-video-speed succeeded 
INFO: default-video-quality succeeded 
SEVERE: default-video-speed failed: 
app.revanced.patcher.patch.PatchResultError: 'default-video-speed' depends on 'default-video-speed-bytecode-patch' but the following error was raised: Failed to resolve LiveLabelFingerprint
	at app.revanced.patcher.Patcher.executePatches$executePatch(Patcher.kt:304)
	at app.revanced.patcher.Patcher.access$executePatches$executePatch(Patcher.kt:36)
	at app.revanced.patcher.Patcher$executePatches$1.invokeSuspend(Patcher.kt:350)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:129)
	at app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:83)
	at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:20)
	at app.revanced.cli.command.MainCommand.run(MainCommand.kt:161)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at app.revanced.cli.main.MainKt.main(Main.kt:7)
INFO: disable-haptic-feedback succeeded 
INFO: enable-external-browser succeeded 
INFO: enable-minimized-playback succeeded 
INFO: enable-old-layout succeeded 
INFO: enable-old-quality-layout succeeded 
INFO: enable-open-links-directly succeeded 
INFO: enable-seekbar-tapping succeeded 
INFO: enable-tablet-miniplayer succeeded 
INFO: enable-timestamps-speed succeeded 
INFO: enable-wide-searchbar succeeded 
INFO: force-vp9-codec succeeded 
INFO: header-switch succeeded 
INFO: hide-auto-captions succeeded 
INFO: hide-auto-player-popup-panels succeeded 
INFO: hide-autoplay-button succeeded 
INFO: hide-button-container succeeded 
INFO: hide-captions-button succeeded 
INFO: hide-cast-button succeeded 
INFO: hide-channel-watermark succeeded 
INFO: hide-collapse-button succeeded 
INFO: hide-comment-component succeeded 
INFO: hide-create-button succeeded 
INFO: hide-crowdfunding-box succeeded 
INFO: hide-email-address succeeded 
INFO: hide-endscreen-cards succeeded 
INFO: hide-endscreen-overlay succeeded 
INFO: hide-filmstrip-overlay succeeded 
INFO: hide-floating-microphone succeeded 
INFO: hide-flyout-panel succeeded 
INFO: hide-fullscreen-buttoncontainer succeeded 
INFO: hide-fullscreen-panels succeeded 
INFO: hide-general-ads succeeded 
INFO: hide-info-cards succeeded 
INFO: hide-live-chat-button succeeded 
INFO: hide-mix-playlists succeeded 
INFO: hide-music-button succeeded 
INFO: hide-next-prev-button succeeded 
INFO: hide-pip-notification succeeded 
INFO: hide-player-button-background succeeded 
INFO: hide-player-overlay-filter succeeded 
INFO: hide-seekbar succeeded 
INFO: hide-shorts-button succeeded 
INFO: hide-shorts-component succeeded 
INFO: hide-shorts-pivot-bar succeeded 
INFO: hide-snackbar succeeded 
INFO: hide-startup-shorts-player succeeded 
INFO: hide-stories succeeded 
INFO: hide-suggested-actions succeeded 
INFO: hide-time-stamp succeeded 
INFO: hide-tooltip-content succeeded 
INFO: hide-video-ads succeeded 
INFO: layout-switch succeeded 
INFO: microg-support succeeded 
INFO: optimize-resource succeeded 
INFO: overlay-buttons succeeded 
INFO: patch-options succeeded 
INFO: return-youtube-dislike succeeded 
INFO: settings succeeded 
INFO: sponsorblock succeeded 
INFO: swipe-controls succeeded 
INFO: switch-create-notification succeeded 
INFO: theme succeeded 
INFO: translations succeeded 
INFO: Compiling resources 
INFO: Writing modified dex files 
INFO: Aligning YouTube-18-08-39.apk to YouTube-Revanced-18-08-39_aligned.apk 
INFO: Signing YouTube-Revanced-18-08-39_aligned.apk to YouTube-Revanced-18-08-39_signed.apk 
INFO: Found existing keystore: revanced.keystore 
INFO: Copying YouTube-Revanced-18-08-39_signed.apk to YouTube-Revanced-18-08-39.apk 
INFO: Cleaned up cache directory 
INFO: Finished 



Variant: nonRoot
Arch: arm64-v8a
App: YouTube-18-08-39.apk
CLI: inotia00-cli-v2.21.0.jar
Patches: inotia00-patches-v2.164.24.jar
Integrations: inotia00-integrations-v0.99.24.apk
Patches argument: -i client-spoof
-i custom-branding-icon-revancify
-i custom-branding-name
-i custom-seekbar-color
-i custom-video-speed
-i default-video-quality
-i default-video-speed
-i disable-haptic-feedback
-i enable-external-browser
-i enable-minimized-playback
-i enable-old-layout
-i enable-old-quality-layout
-i enable-open-links-directly
-i enable-seekbar-tapping
-i enable-tablet-miniplayer
-i enable-timestamps-speed
-i enable-wide-searchbar
-i force-vp9-codec
-i header-switch
-i hide-auto-captions
-i hide-auto-player-popup-panels
-i hide-autoplay-button
-i hide-button-container
-i hide-captions-button
-i hide-cast-button
-i hide-channel-watermark
-i hide-collapse-button
-i hide-comment-component
-i hide-create-button
-i hide-crowdfunding-box
-i hide-email-address
-i hide-endscreen-cards
-i hide-endscreen-overlay
-i hide-filmstrip-overlay
-i hide-floating-microphone
-i hide-flyout-panel
-i hide-fullscreen-buttoncontainer
-i hide-fullscreen-panels
-i hide-general-ads
-i hide-info-cards
-i hide-live-chat-button
-i hide-mix-playlists
-i hide-music-button
-i hide-next-prev-button
-i hide-pip-notification
-i hide-player-button-background
-i hide-player-overlay-filter
-i hide-seekbar
-i hide-shorts-button
-i hide-shorts-component
-i hide-shorts-pivot-bar
-i hide-snackbar
-i hide-startup-shorts-player
-i hide-stories
-i hide-suggested-actions
-i hide-time-stamp
-i hide-tooltip-content
-i hide-video-ads
-i layout-switch
-i microg-support
-i optimize-resource
-i overlay-buttons
-i patch-options
-i return-youtube-dislike
-i settings
-i sponsorblock
-i swipe-controls
-i switch-create-notification
-i theme
-i translations

Screenshots or videos

No response

Solution

No response

Additional context

No response

Device Environment

Android 10, arm64-v8a, nonRoot

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@colbyashilewis11 colbyashilewis11 added the Bug report Something isn't working label Mar 13, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.164.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants