Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: protobuf-spoof patch broke the feature that showing thumbnails when tapping seekbar #481

Closed
3 tasks done
VadimMillerVMMR opened this issue Mar 14, 2023 · 12 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@VadimMillerVMMR
Copy link

Type

Other

Application

YouTube 18.09.39, patches version 2.164.32.

Bug description

Frame-by-frame rewind doesn't work and also there's no the video preview when tap on the seek bar.

Steps to reproduce

  1. Open any video
  2. Try to use frame-by-frame rewind (pull your finger up from the current location in the video.)
  3. There is only a vibration when pulling the finger up. Also, there's no video preview when tap on the seek bar.

Relevant log output

Screenshots or videos

Screenrecorder-2023-03-14-17-19-37-951.mp4

Solution

No response

Additional context

No response

Device Environment

Android 13, MIUI 14.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@VadimMillerVMMR VadimMillerVMMR added the Bug report Something isn't working label Mar 14, 2023
@jhon1282
Copy link

Same issue

VID_20230314_162018.mp4

YouTube stock

VID_20230314_161753.mp4

@inotia00 inotia00 changed the title bug: <Frame-by-frame rewind doesn't work> bug: protobuf-spoof patch broke the feature that showing thumbnails when tapping seekbar Mar 14, 2023
@inotia00
Copy link
Owner

Exclude the protobuf-spoof patch until the issue is fixed

@Ackmard
Copy link

Ackmard commented Mar 15, 2023

I'm having the same issue even without the patch.

@inotia00
Copy link
Owner

  1. Patch again with revanced-patches-v2.165.1
  2. If you have video buffer issues on your device, change Enable protobuf spoof to ON
    2-1. Change Select protobuf to spoof to ON

@Ackmard
Copy link

Ackmard commented Mar 15, 2023

  1. Patch again with revanced-patches-v2.165.1
  2. If you have video buffer issues on your device, change Enable protobuf spoof to ON
    2-1. Change Select protobuf to spoof to ON

That fixed it, also ambient mode seems fixed for me as well.

@madhurvarshney
Copy link

madhurvarshney commented Mar 15, 2023

  1. Patch again with revanced-patches-v2.165.1
  2. If you have video buffer issues on your device, change Enable protobuf spoof to ON
    2-1. Change Select protobuf to spoof to ON

Can anyone please explain me what "Select protobuf to spoof" option does and in what case should it be enabled/disabled?
Because the video playback issue seems to be resolved when "Enable protobuf spoof" is turned ON, irrespective of "Select protobuf to spoof".
The only differences I could currently find are:

  1. When the "Select protobuf to spoof" is OFF, the captions appear at the bottom but the thumbnails are not shown when tapping seekbar and ambient mode also doesn't work.
  2. When it is ON, the thumbnails are shown when tapping seekbar and ambient mode also works fine but now the captions appear at the top.

@inotia00
Copy link
Owner

inotia00 commented Mar 15, 2023

yeah it's exactly what you wrote
I couldn't fix all three issues at once, so I just added them all to the settings so that the user can select one of the three options.

@FlamySan
Copy link

Spoofing protobuf as shorts also bugs endscreen cards. They're not shown at the end of a video. Also the watch history is bugged again #475

@inotia00
Copy link
Owner

There is no valid fix for this

If you don't want to face this issue, just turn off the protobuf-spoof

@FlamySan
Copy link

@inotia00 I've a good news..watch history seems to have been fixed on 18.12.34 with latest patch when protobuf is spoofed as shorts. The endscreen & subtitle remain broken though.

@madhurvarshney
Copy link

@inotia00 I've a good news..watch history seems to have been fixed on 18.12.34 with latest patch when protobuf is spoofed as shorts. The endscreen & subtitle remain broken though.

Yeah, even on v18.11.35 with patch v2.166.12, the watch history seems to be fixed when protobuf is spoofed as shorts.

@inotia00
Copy link
Owner

inotia00 commented Apr 2, 2023

fixed in revanced-patches-v2.168.1

@inotia00 inotia00 closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants