bug: App crashes when "Hide shorts player pivobar" option is enabled

[buiducanh142qn]

Type

Error at runtime

Application

YouTube v18.09.39 (revanced-patches-2.165.1)

Bug description

App crashes 1 time when "Hide Shorts player at app startup" option is disabled and "Hide Shorts player pivobar" is enabled.

Steps to reproduce

When you set up the RVX Settings like this:

1. Disable "Hide shorts player at app startup".
2. Enable "Hide shorts player pivobar"
   Then watch any short video and restart app, it will crash 1 time.

Relevant log output

-

Screenshots or videos

doc_2023-03-15_18-21-14.mp4

Solution

No response

Additional context

No response

Device Environment

Redmi K20 Pro
Android 11, MIUI 12.5.6

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[inotia00]

I found the cause of this issue

Patch to hide Paid Promotion banner on shorts players causes crash

This patch is difficult to work with dynamically due to structural limitations, and often breaks.

So I decided to just drop the features that hide the Paid Promotion banner on shorts players.

[inotia00]

fixed in revanced-patches-v2.166.5