Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Swipe controls doesn't work on recent version of patches #505

Closed
3 tasks done
Faszom11 opened this issue Mar 17, 2023 · 7 comments
Closed
3 tasks done

bug: Swipe controls doesn't work on recent version of patches #505

Faszom11 opened this issue Mar 17, 2023 · 7 comments
Labels
Bug report Something isn't working

Comments

@Faszom11
Copy link

Type

Error at runtime

Application

Youtube version 18.10.36

Bug description

After patching when you first open youtube it works just fine, when you setup your layout (e.g. enable/disable various features) and close the app, on reopening the swipe controls become buggy and won't work. (Screenshot of layout setup included below)

Steps to reproduce

Open youtube, set up layout, open a video and swipe up / down.

Relevant log output

No logs

Screenshots or videos

Screenshot_20230317_171827_YouTube RobEdition

VideoEditor_20230317_050447.mp4

Solution

No response

Additional context

Selected patches:

Variant: nonRoot
Arch: arm64-v8a
App: YouTube-18-10.36.apk
CLI: inotia00-cli-v2.21.0.jar
Patches: inotia00-patches-v2.166.1.jar
Integrations: inotia00-integrations-v0.100.2.apk
Patches argument: -i custom-branding-icon-afn-red
-i custom-branding-name
-i custom-video-speed
-i default-video-quality
-i enable-external-browser
-i enable-minimized-playback
-i enable-old-quality-layout
-i enable-seekbar-tapping
-i force-premium-heading
-i hide-auto-captions
-i hide-auto-player-popup-panels
-i hide-channel-watermark
-i hide-email-address
-i hide-endscreen-cards
-i hide-general-ads
-i hide-info-cards
-i hide-mix-playlists
-i hide-player-button-background
-i hide-video-ads
-i microg-support
-i optimize-resource
-i overlay-buttons
-i patch-options
-i return-youtube-dislike
-i settings
-i sponsorblock
-i swipe-controls
-i theme

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Faszom11 Faszom11 added the Bug report Something isn't working label Mar 17, 2023
@Faszom11 Faszom11 changed the title bug: Swipe controls doen't work on recent version of patches bug: Swipe controls doesn't work on recent version of patches Mar 17, 2023
@inotia00
Copy link
Owner

it's weird..
because it works fine for me

Could you please export and upload the ReVanced settings json file?

@Faszom11
Copy link
Author

Faszom11 commented Mar 17, 2023

Yes sure, how can I upload the json file here? (Sorry, I'm a noob on github, just registered a couple day ago)

@Faszom11
Copy link
Author

Got it, just zipped it and now it let me add it as attachment.
YouTube RobEdition_v18.10.36_2023-03-17.zip

@inotia00
Copy link
Owner

great
In a little while I will proceed with patching in the same environment, do a clean install, and import these settings.

Then I'll check if the issue reproduces.

@Faszom11
Copy link
Author

Thank you for your work, you're the best!

@inotia00
Copy link
Owner

inotia00 commented Mar 17, 2023

ahh.. fortunately, the issue was reproduced with the json file you uploaded, and I found the cause

hide-autoplay-preview patch was the cause

turn on the following settings:

Settings - ReVanced Settings - Fullscreen Layout - Hide autoplay preview

This issue will be fixed in the next releases

@inotia00
Copy link
Owner

fixed in revanced-patches-v2.166.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants