Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SponsorBlock "Time with Skips Removed" and Video Speed in Right to Left Languages #506

Closed
3 tasks done
blacktornadog7 opened this issue Mar 17, 2023 · 12 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@blacktornadog7
Copy link

blacktornadog7 commented Mar 17, 2023

Type

Cosmetic

Application

YouTube 18.08.39

Bug description

In Right to Left Languages the "x" from the video speed (as in 1.0x, 1.25x...) comes after the SponsorBlock "Time with Skips Removed" instead. (screenshot below)

Steps to reproduce

  1. Change Youtube's display language to a right to left language
  2. Enable SponsorBlock
  3. Play a video with skippable segments

Relevant log output

no logs

Screenshots or videos

What it looks like:

Screenshot_20230317_114303_ReVanced Extended

What it's supposed to look like:

Screenshot_20230318_003212_ReVanced Extended

Solution

🤷🤷🤷

Additional context

No response

Device Environment

Android 13 (One UI 5)

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@blacktornadog7 blacktornadog7 added the Bug report Something isn't working label Mar 17, 2023
@inotia00
Copy link
Owner

fixed in revanced-patches-v2.166.4

@blacktornadog7
Copy link
Author

blacktornadog7 commented Mar 19, 2023

Broken but in a different way:

Screenshot_20230320_004325_ReVanced Extended

(I don't know if I should open a new issue or not?)
P.S @inotia00 I just wanted to say you're a legend for making this whole fork in the first place, maintaining it by yourself and with the rate you're fixing and adding new features, simply kudos to you, thanks a lot.

@inotia00
Copy link
Owner

inotia00 commented Mar 19, 2023

What do you mean? Does the issue still reproduce even after updating to the latest patch?

@blacktornadog7
Copy link
Author

Yes it does even with the latest patch, I even double checked when Installing.
(but it's a little different now, before the bug was that the time and speed sort of switched places and the "x" came after the time instead, now It's the the dot that should be between the time and the speed is between the speed and the "x")

@inotia00
Copy link
Owner

When tested on another device using AOSP ROM, the issue was reproduced.

Maybe.. my main device doesn't support RTL layout (but why..?)

Anyway, this issue is still valid, so I'll reopen it

@inotia00 inotia00 reopened this Mar 20, 2023
@inotia00
Copy link
Owner

Fortunately, this issue seems to be fixable.

It will be reflected in the next release

by the way.. This project is a kind of talent donation that goes on without any donations or sponsors.

I know you're upset, but I hope you'll be a bit more polite when reporting issues.

@blacktornadog7
Copy link
Author

I'm not upset in any way? why would I be?
And I'm really sorry if anything I said came out as impolite, I was joking and had nothing but praise, idk I thought I made that
clearly obvious?
Anyway my bad, sorry again.

@inotia00
Copy link
Owner

fixed in revanced-patches-v2.166.10

@inotia00
Copy link
Owner

ReVanced

@blacktornadog7
Copy link
Author

is it possible for the "time with skipped segments" and speed to come after the full length as in normal (non RTL layout) ?

@blacktornadog7
Copy link
Author

broken again after being fixed in Revanced:

Screenshot_20230426_025446_ReVanced Extended

@inotia00
Copy link
Owner

Unfortunately, no further fixes are planned.

Use the official ReVanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants