Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: hide-player-button-background patch makes animations hidden #569

Closed
3 tasks done
BrilliantlyEducated opened this issue Mar 26, 2023 · 5 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@BrilliantlyEducated
Copy link

BrilliantlyEducated commented Mar 26, 2023

Type

Error at runtime

Application

verizon 18.11.36

Bug description

when i hide player button background, tapping on the video player makes the animation of the shadow filter a little bit laggy compared to the hide player button background patch by ReVanced Team

Steps to reproduce

turn on Hide player button background feature

Relevant log output

.

Screenshots or videos

ReVanced

4_5800647542802747480.mp4

ReVanced Extended

4_5800647542802747479.mp4

Solution

No response

Additional context

No response

Device Environment

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@BrilliantlyEducated BrilliantlyEducated added the Bug report Something isn't working label Mar 26, 2023
@inotia00 inotia00 changed the title lag report bug: hide-player-button-background patch makes animations hidden Mar 26, 2023
@inotia00
Copy link
Owner

This issue can be completely fixed, but in that case you won't be able to control ON/OFF via settings

@BrilliantlyEducated
Copy link
Author

BrilliantlyEducated commented Mar 26, 2023

that's fine

@BrilliantlyEducated
Copy link
Author

BrilliantlyEducated commented Mar 26, 2023

please unblock me on Telegram if you want

@inotia00
Copy link
Owner

The force-player-button-background patch added in revanced-patches-v2.166.18 fixes this issue.

Instead, you should exclude the hide-next-prev-button patch.
And.. You must do a clean install.
(Importing previously exported settings after a clean install does not solve the issue.)

@BrilliantlyEducated
Copy link
Author

BrilliantlyEducated commented Mar 27, 2023

thank you for adding a patch to fix this issue and letting me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants