-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements #2611
Minor improvements #2611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3f1da26
to
9f771f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Might want to give more descriptive names to the pseudo-projction functions that test if one of the fields in a Triple is Just or Nothing.
…tribution calculation
…hat compares it with incremental. Minor additions to UMap
9f771f6
to
d6a8ecf
Compare
This is a tiny PR that adds some bangs on data types that seem to have them missing.
It also simplifies recently added code just a tiny bit.
Please ignore changes to benchmark suite, they aren't important.