Generalized the generic unit tests in TwoPhaseValidation.hs #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Mar 2, 2022
There was a problem hiding this comment.
There are a few minor questions and changes suggested in this review. I'd like to ask @JaredCorduan to review this PR as well, some of the changes are introduced to places of the codebase that I am not very familiar with.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Proof.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
reviewed
Mar 2, 2022
There was a problem hiding this comment.
@TimSheard this PR looks great. The only thing we still need to clean up here is the fact that missingRequiredDatums isn't quite correct for Babbage (see my comment above).
lehins
reviewed
Mar 2, 2022
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/TwoPhaseValidation.hs
Show resolved
Hide resolved
lehins
approved these changes
Mar 3, 2022
in both Alonzo and Babbage eras. Fixed some errors in Updaters.hs Added txOutView to UsesTxOut.
TimSheard
force-pushed
the
ts-babbage-unittests
branch
from
b66deda to
f7845d8
Compare
JaredCorduan
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests now work in both Alonzo and Babbage eras. Fixed some errors in Updaters.hs
This constitutes a good base of unit tests for the Babbage Rules. They do not do Babbage specific things.