Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional tests need to be fixed for CI #16

Open
zenspider opened this issue Jul 1, 2019 · 2 comments
Open

functional tests need to be fixed for CI #16

zenspider opened this issue Jul 1, 2019 · 2 comments
Labels

Comments

@zenspider
Copy link
Contributor

They're all being skipped because they need ENV vars set to actually hit AWS. I don't know how realistic this is for our CI setup.

@clintoncwolfe
Copy link
Collaborator

Historically, this was left as an unsolved problem; the fear was that if CI was able to run live tests against the cloud, an unscrupulous contributor could submit a PR that would (mascarading as a test) spin up instances for (say) bitcoin mining. There was also the problem of secrets management. None of those problems are unsolvable, but setting the ENV manually and running the tests locally is the short-term solution.

Provided as context, not as a counter-argument to doing the work.

@james-stocks
Copy link

Actually hitting AWS might be difficult (or at least too heavy testing for a gem). If we never fix this; we should at least add some testing e.g. we have a loadable gem, or one that gets as far as failing due to missing config. Will file a separate issue for that; we'd want to keep this issue for "real AWS" testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants