Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimum python versions #135

Merged
merged 7 commits into from
May 26, 2022
Merged

bump minimum python versions #135

merged 7 commits into from
May 26, 2022

Conversation

jhamman
Copy link
Collaborator

@jhamman jhamman commented May 25, 2022

No description provided.

@jhamman jhamman requested a review from scottyhq May 25, 2022 15:49
@jhamman jhamman mentioned this pull request May 25, 2022
@scottyhq
Copy link
Collaborator

scottyhq commented May 25, 2022

test_drivers_include_all_pystac_media_types test failing with upstream environment:

AssertionError: assert <MediaType.PDF: 'application/pdf'> in {'application/geo+json': 'geopandas', 'application/geopackage+sqlite3': 'geopandas', 'application/json': 'textfiles', 'application/netcdf': 'netcdf', ...}

So pystac has added the application/pdf media type, which looks like is used for things like product documentation links: https://github.com/stac-utils/pystac/blob/a8f50cba92e27c9e1630bb8332523e9d06ee9cc4/tests/data-files/examples/1.0.0-beta.2/extensions/sar/examples/envisat.json#L80-L82

    "links": [
        {
            "rel": "about",
            "href": "https://earth.esa.int/pub/ESA_DOC/ENVISAT/ASAR/asar.ProductHandbook.2_2.pdf",
            "title": "ASAR Product Handbook",
            "type": "application/pdf"
        },

I'm just going to add a special case to that test...

Copy link
Collaborator

@scottyhq scottyhq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhamman - gave the CI a much needed update, and I think we're good to go now if you want to merge this, add to the changelog, and release 0.4.

@jhamman jhamman merged commit dd76de3 into intake:main May 26, 2022
@jhamman jhamman deleted the maint/update-deps branch May 26, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants