Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code #917

Open
wilhelmklopp opened this issue Aug 21, 2019 · 4 comments
Open

Remove dead code #917

wilhelmklopp opened this issue Aug 21, 2019 · 4 comments
Labels
good first issue type:chore Not user facing, but would ease maintenance or operations

Comments

@wilhelmklopp
Copy link
Contributor

This method doesn't seem like it's in use, so we should probably remove it?

slack/lib/messages/issue.js

Lines 24 to 26 in 0cfaaba

get identifier() {
return `issue#${this.issue.id}`;
}

@wilhelmklopp wilhelmklopp added type:chore Not user facing, but would ease maintenance or operations good first issue labels Aug 21, 2019
@mitulsavani
Copy link

Hi @wilhelmklopp Can i work on this and submit a PR?
Please LMK

@msrattikan155
Copy link

msrattikan155 commented Apr 5, 2020 •
edited
Loading

😃

Hi @wilhelmklopp Can i work on this and submit a PR?
Please LMK

@msrattikan155
Copy link

😃

@PrathameshAshra
Copy link

If this is still active, can i do this ?

@snyk-bot snyk-bot mentioned this issue Nov 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue type:chore Not user facing, but would ease maintenance or operations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wilhelmklopp @mitulsavani @PrathameshAshra @msrattikan155