Post comments to PRs as Slack Thread replies

[timexcession]

It would be neat if the PR integration would create and manage slack threads.

We have a pretty busy repo, with many PRs on going at once - it would be great if each PR could be managed through a thread on slack rather than having to search and filter an entire channel.

This relates to: #660

Thanks for considering!

[welcome]

Thanks for opening this issue! If you would like to help implement an improvement, read more about contributing and consider submitting a pull request.

[Startouf]

On a similar topic, it would be great if PR reviews (which seem to be considered separately than PR comments) could also be sent to the thread started by the pulls notification "Pull request opened by x" if it exists.

The difficulty of this feature (both for reviews and comments) is finding the original message(s).

Right now it's possible to subscribe to PR notifications (+ comments/reviews) in any slack channel, so the code would require to try to find all the non-threaded messages in each channel the notification should be sent to, if they exist (because it's possible to subscribe to PR notifications/comments even if the original PR message was not sent to Slack).

My suggestion to handle PR reviews and comments in thread (I'm not sure about the feasibility of the search part)

1. Change the original PR notification message to include the issue number and the repo name, so we can find it much more easily when searching messages.

GitHubAPP  3:15 PM
Pull request opened by X
 + attachment

Should become

GitHubAPP  3:15 PM
Pull request #{PR_NUMBER} opened in {repo_name} by X
 + attachment

2. Before posting a comment/review, search in slack, in each channel the subscription is active, to find a message containing exactly Pull request #{PR_NUMBER} opened in {repo_name}. Take the last matching message in each channel (by created date), its ID will become the relevant thread_id of the channel.

I'm not sure this type of search is supported/it would require extra permissions

3. in each channel the subscription is active, either we have found a thread_id or we have not => either send the message threaded under the message with thread_id or send the notification as a new message

[ghost]

The fact that pull-request has so much slack channel space caused my team to disable it. We are jus pasting the PR link when we want a review. I think it would be good to have it automated. But it neeeds to be more compact.

A thread with details would be a good start.

Emoji updates to original post would also be good.

476 issue-989 SEAL-15000 Udate 3rd party dependencies
:changes-requested: :test-ok: :merged:

476 issue-989 SEAL-15000 Udate 3rd party dependencies
👍 💯 🍡

I guess better emojies than my example but you get the point.

[OBorce]

👍 for this

[sidvenu]

+1 to this feature request. My organization needs this immensely.

[moonjoungyoung]

+1 to this feature. This feature is awesome.

[Sovianum]

+1

[zchbndcc9]

+1

[michaeloliverx]

+1

[haigopi]

+1

[ivan-nezhura]

+1

[katedoctor]

• 1

[nareshkumaryadav]

+1

[nusija42]

+1

[adri1wald]

+1

[alokCrewFoundry]

Has this been added in the Roadmap?

[mhuisman]

+1. One PR per thread, please.

[estellise-yukihime]

👍🏼

[awlevin]

+1

[jordie23]

Is this likely to become a thing?

[fgarcia44]

+1

[rubencodes]

+1

[isaak-a]

+1

[JenniferBuehler-TomTom]

+1

[arnold-almeida]

This would be a great feature.

In our team we generally post a PR in the engineering channel once a PR is ready for review and we use tags to indicate the status of the PR.

If PR comments were updated in that thread it would greatly improve the general feedback loop.

[alexfoxy]

+1

[ivorynoise]

+1

[pmiroslaw]

+1

[kdmgs110]

+1

[Zinkutal]

+1

[efojs]

Add type:feature to this issue

[razhollander-monkeyleague]

+1

[vovasaz]

+1

[isaac-abotsi-mt]

+1

[ariefaprilianto]

It's been three years

[cosydney]

Hey,

for those interested in being able to have Slack conversations that are synced with GitHub we developed Axolo. Axolo creates an ephemeral channel for each pull request that gets archived whenever your merge or close your pull requests on GitHub. In the dedicated channel you can make pull request comment, code comments and get notified of your GitHub checks.

This integration helps in making team productive by picking up and reviewing pull requests faster while keeping all your context in a single place: Slack.

Happy to make a demo if anyone wants, just contact us in the chat on https://axolo.co

[evgi88]

+1 for the feature

[gregsdennis]

I just started getting this in one of my slack workspaces. Is it possible to turn this off? I use the integration more as an RSS feed, and it's hard to see where new comments come in.

[sorah]

It is impossible to notice updates on issues/PRs if it is posted on thread. threads add nothing usefulness.

[gregsdennis]

In several of my workspaces, this change has completely broken me. I have many GH issues and PRs that I'm following that all feed into Slack. But Slack can only have a single thread open at once. Please revert this change or add a way to disable it.

[ShuzoN]

Please revert this change or add a way to disable it.

I agree this idea. Please add subscribe option "also send to #channel".

[xavierlacot]

Please make this change optional.

[TheMadBug]

This feature turned out to probably be the most hated change in this repo's history. (at least for how it applies to issue comment threading).
Here's a feature request to remove it #1500 currently at 382 upvotes. Can we admit that the grand majority of users do not want this, and if made configurable it should not be the default?

I sympathise that a bunch of people requested the feature, and so you did the work and implemented it as asked. THEN a lot more people jumped out of the woodwork and told they hated it. But that's sometimes the risk of feature development.

[andrewsw]

Just moseying by to report that between this issue and #1500, we wasted roughly 2 hours of developer time getting our subscriptions reworked into something usable for us. This could have been handled significantly better.

In the end, via undocumented (AFAICT) reviews:'channel' we were able to get it working the way we like, but it didn't need to be this difficult. Opt-in for major interface changes is the way to go, IMO.

Thanks, though, for all the work on this integration.

[TrevorSayre]

We found that the threads are handy for colocation of information, but also wanted the thread posts to echo to the channel. So we left threads enabled with /github settings and also enabled comments and reviews to be posted to the channel as well as the thread via:

/github subscribe org/repo comments:"channel"
/github subscribe org/repo reviews:"channel"

Thanks for adding these, although the README only seems to mention the comments option, but the reviews option also worked. (Edit: README updated)

[lyderichti59]

I find that the threads handy for colocation of information (it fits my flow/taste), but don't want the thread posts to echo to the channel (as it makes the channel noisy IMHO and I'd like to keep it thread centric).
How should I go about it ? It looks like by defaults, they echo and all slack comments are also sent to the channel.
Is there a way to keep the threading feature enabled but disable echoing to the channel ?

[andrewsw]

@lyderichti59 check your subscriptions, /github subscribe list features, for instances of comments:"channel" and reviews:"channel". Those are what cause it to echo to the channel. Replace them with just comments and reviews to get them threaded.

If you don't have those "channel" items, then you might need to just redo your subscriptions. It seems the migration might leave things in a somewhat inconsistent state. At least, that was our experience.

[lyderichti59]

Thanks for your help.
I've listed the features, the comments:"channel" and reviews:"channel" didn't appear.
So, I have unsubscribed to the repo, and re-subscribed to it.
I created a PR and closed it to trigger the behaviour.
Unfortunately, 'Pull request closed by @lyderichti59' slack message was successfully added to the thread of the PR creation, but it was also echoed in the channel although reviews and comments are not enabled.

I've tried to subscribe to comments and reviews too (explicitely, and without the "channel" part) and reopened + reclosed the previously created PR. It didn't work either : both 'reopen' and 'closed' slack messages were re-sent to the channel too.

Thanks for trying to help. Still stuck so far 🤔

[aquinq]

Here is how to disable this feature : https://github.com/integrations/slack#dont-want-threading

[Serubin]

Thanks for posting how to disable this.

While threads may provide context, they also make Slack's "Thread" panel effectively useless for tracking actual conversations. After this change appeared and before I disabled it for my organization, I had 70 new threads that mostly consisted of "PR Merged." All of the threads I was tracking are now effectively lost to the depth of the infinite scroll.

[taoruicui]

+1

[ahmed-hamza-k24]

/github subscribe

@lyderichti59
Did you find any solution for the issue - disable echo message on channel?

[Mrc0113]

+1

[ziwengua]

+1

[adrian-85]

+1

[mvinayku]

I have created my own YAML file which posts notifications to Slack thread.

[jack-rep]

seems it now uses threads via /github settings, but posts in channel too. Would be nice to have an option to not post in channel too. Just thread.