Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIRVRunner: Investigate and handle multi-kernel execution (benchmark- gemm_streamk_benchmark.py) #2831

Open
kballeda opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kballeda
Copy link
Contributor

Describe the bug

Benchmarks such as - benchmark/triton_kernels_benchmark/gemm_streamk_benchmark.py uses two kernels as part of the execution. Investigate this scenario and if possible improve the SPIRVRunner to handle such cases.

     _, min_ms, max_ms, mean_ms, cv = benchmark_suit.do_bench(triton_fn, n_warmup=10, n_repeat=10,
                                                                 quantiles=quantiles,
                                                                 kernel_name=['first_wave', 'full_tiles'])

Environment details

This is an enhancement request. Triton: main, GPU: Max 1100.

@kballeda kballeda added the enhancement New feature or request label Nov 26, 2024
@kballeda kballeda self-assigned this Nov 26, 2024
@alexbaden
Copy link
Contributor

Each kernel should dump to a different file, and the SPIRV runner can be run twice - once with the inputs from the first kernel and its args and SPIRV file, and once with the inputs from the second kernel and its args and SPIRV file. The runner was never designed to run both kernels at the same time and I don't see the need to add that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants