From 1332f7ae6d957523f9b4c49bfb5e01c8c4ea6b7a Mon Sep 17 00:00:00 2001 From: Yi Zhang Date: Wed, 8 Feb 2023 12:45:37 +0800 Subject: [PATCH] Revert "try VS 2022 in windowsAI pipeline (#14608)" (#14619) This reverts commit f88a4646cdb47f106fc0838426dabe362353321d. ### Description ### Motivation and Context For release, winai packaing pipeline's container image is revert to old image. So we should revert VS to 2019 --- .pipelines/windowsai-steps.yml | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.pipelines/windowsai-steps.yml b/.pipelines/windowsai-steps.yml index d246b326764a2..aa9ec339c7b2a 100644 --- a/.pipelines/windowsai-steps.yml +++ b/.pipelines/windowsai-steps.yml @@ -3,12 +3,12 @@ parameters: displayName: BuildArch type: string default: 'x64' - + - name: Runtime displayName: MSVC Runtime, should be 'dynamic' or 'static'. type: string default: 'dynamic' - + - name: PythonPackageName displayName: PythonPackageName on nuget.org to use type: string @@ -17,8 +17,8 @@ parameters: jobs: - job: Windows_Packaging_${{ parameters.BuildArch }}_${{ parameters.Runtime }} pool: - type: windows - + type: windows + variables: ob_outputDirectory: '$(Build.ArtifactStagingDirectory)' ob_sdl_binskim_break: true @@ -40,7 +40,7 @@ jobs: restoreSolution: $(Build.SourcesDirectory)\.pipelines\nuget_config\x64\packages.config ${{ if eq(parameters.BuildArch, 'arm64') }}: restoreSolution: $(Build.SourcesDirectory)\.pipelines\nuget_config\x64\packages.config - + - script: | @echo off set vswherepath="%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" @@ -50,10 +50,10 @@ jobs: set vsdevcmd="%%i\Common7\Tools\vsdevcmd.bat" ) ) - + @echo vslatest %vslatest% @echo vsdevcmd %vsdevcmd% - + @echo ##vso[task.setvariable variable=vslatest]%vslatest% @echo ##vso[task.setvariable variable=vsdevcmd]%vsdevcmd% -arch=${{ parameters.BuildArch }} displayName: 'locate vsdevcmd via vswhere' @@ -80,7 +80,7 @@ jobs: 7z x cmake-3.24.3-windows-x86_64.zip set PYTHONHOME=$(Build.BinariesDirectory)\${{ parameters.PythonPackageName }}.3.7.9\tools set PYTHONPATH=$(Build.BinariesDirectory)\${{ parameters.PythonPackageName }}.3.7.9\tools - $(Build.BinariesDirectory)\${{ parameters.PythonPackageName }}.3.7.9\tools\python.exe "$(Build.SourcesDirectory)\tools\ci_build\build.py" --build_dir $(Build.BinariesDirectory) --build_shared_lib --enable_onnx_tests --ms_experimental --use_dml --use_winml --cmake_generator "Visual Studio 17 2022" --update --config RelWithDebInfo --enable_lto --use_telemetry --disable_rtti --enable_wcos $(BuildFlags) --cmake_extra_defines CMAKE_SYSTEM_VERSION=10.0.19041.0 --cmake_path $(Build.BinariesDirectory)\cmake-3.24.3-windows-x86_64\bin\cmake.exe --ctest_path $(Build.BinariesDirectory)\cmake-3.24.3-windows-x86_64\bin\ctest.exe + $(Build.BinariesDirectory)\${{ parameters.PythonPackageName }}.3.7.9\tools\python.exe "$(Build.SourcesDirectory)\tools\ci_build\build.py" --build_dir $(Build.BinariesDirectory) --build_shared_lib --enable_onnx_tests --ms_experimental --use_dml --use_winml --cmake_generator "Visual Studio 16 2019" --update --config RelWithDebInfo --enable_lto --use_telemetry --disable_rtti --enable_wcos $(BuildFlags) --cmake_extra_defines CMAKE_SYSTEM_VERSION=10.0.19041.0 --cmake_path $(Build.BinariesDirectory)\cmake-3.24.3-windows-x86_64\bin\cmake.exe --ctest_path $(Build.BinariesDirectory)\cmake-3.24.3-windows-x86_64\bin\ctest.exe workingDirectory: '$(Build.BinariesDirectory)' displayName: 'Generate cmake config' @@ -97,7 +97,7 @@ jobs: maximumCpuCount: true logProjectEvents: true workingFolder: '$(Build.BinariesDirectory)\RelWithDebInfo' - createLogFile: true + createLogFile: true - ${{ if eq(parameters.Runtime, 'dynamic') }}: - script: | @@ -114,8 +114,8 @@ jobs: copy $(Build.SourcesDirectory)\onnxruntime\test\testdata\sequence_length.onnx $(Build.ArtifactStagingDirectory)\test_artifact\ copy $(Build.SourcesDirectory)\onnxruntime\test\testdata\sequence_construct.onnx $(Build.ArtifactStagingDirectory)\test_artifact\ displayName: 'Copy WinML test collateral to artifact directory' - - + + - ${{ if eq(parameters.BuildArch, 'x64') }}: - script: | call $(vsdevcmd) @@ -129,8 +129,8 @@ jobs: signing_profile: 'external_distribution' files_to_sign: '**/*.exe;**/*.dll' search_root: '$(Build.BinariesDirectory)\RelWithDebInfo\RelWithDebInfo' - displayName: 'Sign runtime DLLs' - + displayName: 'Sign runtime DLLs' + - ${{ if eq(parameters.BuildArch, 'x64') }}: - script: | call $(vsdevcmd)