Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't onnxruntime-openvino specify the openvino package as a requirement? #357

Closed
adrianboguszewski opened this issue Apr 11, 2024 · 8 comments

Comments

@adrianboguszewski
Copy link

adrianboguszewski commented Apr 11, 2024

Describe the issue

While installing onnxruntime-openvino via pip, the openvino package is not installed by default. One doesn't know:

  1. they must install openvino separetely
  2. which version of openvino they must install
    unless they look to the release notes/docs (imagine how many people abandon the process at this stage).

To reproduce

pip install onnxruntime-openvino

Urgency

No response

Platform

Windows

OS Version

11

ONNX Runtime Installation

Released Package

ONNX Runtime Version or Commit ID

1.17.1

ONNX Runtime API

Python

Architecture

X64

Execution Provider

OpenVINO

Execution Provider Library Version

No response

Copy link

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@github-actions github-actions bot added the stale label May 11, 2024
@adrianboguszewski
Copy link
Author

Don't close. The issue hasn't been solved yet as far as I know.

@github-actions github-actions bot removed the stale label May 13, 2024
@henryruhs
Copy link

@adrianboguszewski It's more like a peerDependency - openvino can be installed via conda as well.

@adrianboguszewski
Copy link
Author

@henryruhs could you elaborate more on what a peer dependency means?

Copy link

github-actions bot commented Jul 3, 2024

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@github-actions github-actions bot added the stale label Jul 3, 2024
@adrianboguszewski
Copy link
Author

Still not resolved...

@henryruhs
Copy link

henryruhs commented Jul 3, 2024

Should not be resolved anyway...

A peer dependency describes a loosy dependency that is either optional or that version cannot be specified. Giving the consumer more freedom.

In this case we can choose to install OpenVino in different ways like pip or conda. Which is a good thing.

@github-actions github-actions bot removed the stale label Jul 4, 2024
Copy link

github-actions bot commented Aug 3, 2024

This issue has been automatically marked as stale due to inactivity and will be closed in 30 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants