Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundled executable file path does not match installed script file path #127

Merged
merged 3 commits into from
Aug 4, 2018

Conversation

hokuma
Copy link
Contributor

@hokuma hokuma commented Apr 6, 2018

Is executable file path check necessary?

Because of this check, below command does nothing.

$ gem install committee
$ committee-stub -h
# nothing to happen

MyEnvironment:

~ $ rbenv -v                                                                                                                                                                                               00:44:37
rbenv 1.1.1-gc8ba27f
~ $ ruby -v                                                                                                                                                                                                00:44:53
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-darwin15]

After inserting debug print in bin/committee-stub and executing it, the resuls is as follows

p $0
=>"MY_HOME/.rbenv/versions/2.4.1/bin/committee-stub"
p __FILE__
=>"MY_HOME/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/committee-2.1.0/bin/committee-stub"

@brandur
Copy link
Member

brandur commented Aug 4, 2018

(Sincere apologies for this epic delay.)

Absolutely right — I don't understand how I never caught this before. I guess because Committee is usually just being bundled into projects. Thank you!

@brandur brandur merged commit 363e35c into interagent:master Aug 4, 2018
@brandur
Copy link
Member

brandur commented Aug 4, 2018

Released as 2.1.1.

momosetkn pushed a commit to momosetkn/committee that referenced this pull request Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants