Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning GET method with request body. #211

Closed
ota42y opened this issue Jan 25, 2019 · 2 comments
Closed

Warning GET method with request body. #211

ota42y opened this issue Jan 25, 2019 · 2 comments

Comments

@ota42y
Copy link
Member

ota42y commented Jan 25, 2019

See: #210

It's our own rule, so the new users are difficult to understand.
So I think we should provide disable/warning option and default disable to avoid using GET request body.
(I'll implement 3.1.0)
@ota42y
Copy link
Member Author

ota42y commented Jan 28, 2019

I think we shouldn't merge it by default in OpenAPI 3.
But it's breaking changes so we should add 3.0.0 release.

ota42y added a commit that referenced this issue Jan 28, 2019
@ota42y
Allow GET request body data
4717f43 
Related: #211

We don't merge GET request body data to get parameter by default.
Because it's commitee original rule so it's difficult to understand.
@ota42y ota42y mentioned this issue Jan 28, 2019
Merged
@ota42y
Copy link
Member Author

ota42y commented Feb 11, 2019

Done

@ota42y ota42y closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ota42y