Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when loading OpenAPI 3.1 schema #418

Merged
merged 1 commit into from
May 4, 2024

Conversation

ytjmt
Copy link
Contributor

@ytjmt ytjmt commented Mar 19, 2024

Hi! Thank you for maintaining this great gem.
It can be confusing when the HyperSchema driver is used while loading the OpenAPI 3.1 schema. I think it would be beneficial to raise an error until OpenAPI 3.1 is officially supported.

#303

I just found a problem when I upgrade OpenAPI version in document to 3.1.0.
The current implementation has locked version to 3.0.x, and fails finding paths for this document.
Current behaviour:

  • runs HyperSchema driver for version OpenAPI version 3.x.x

@brandur
Copy link
Member

brandur commented May 4, 2024

Thanks @ytjmt! Couldn't hurt to be explicit about this.

@brandur brandur merged commit dab46d2 into interagent:master May 4, 2024
brandur added a commit that referenced this pull request May 4, 2024
Follows up #418 with a small future compatibility change so that if an
OpenAPI version is anything equal or greater than 3.1 the error is
produced. Also, add a changelog entry about it.
brandur added a commit that referenced this pull request May 4, 2024
Follows up #418 with a small future compatibility change so that if an
OpenAPI version is anything equal or greater than 3.1 the error is
produced. Also, add a changelog entry about it.
brandur added a commit that referenced this pull request May 4, 2024
Follow up #418 and #419 to really add the promised changelog for
erroring on OpenAPI 3.1+.
@ytjmt ytjmt deleted the raise-error-openapi-3-1 branch May 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants