Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record user key is broken #24

Open
okwme opened this issue Jul 12, 2021 · 1 comment · May be fixed by #21
Open

record user key is broken #24

okwme opened this issue Jul 12, 2021 · 1 comment · May be fixed by #21

Comments

@okwme
Copy link
Contributor

okwme commented Jul 12, 2021

as part of createNewUserKey we attempt to save the mnemonic phrase of the user in a directory called keys. First off the cwd is relevant to the running of the slackbot binary, and not the user's home directory (for instance). secondly the command fails silently.

We should first off confirm whether it's possible to save the user's keys this way (i think the mnemonic phrase might not actually be part of the stdout). If so, we should fix the command so that keys are saved (maybe even throw an error that prevents the creation of a user where this step fails). Finally we should re-migrate all the users keys so that we have a written backup of all of them. All of this would be in service of the functionality to allow users to receive a copy of their mnemonic phrase in order to use their keys outside of slack.

@okwme
Copy link
Contributor Author

okwme commented Jul 12, 2021

i think out of those steps (1-4), 1 and 2 are the most valuable but 3 and 4 should be saved for another issue.

@yaruwangway yaruwangway linked a pull request Jul 15, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant