feat(auth): handle grant choice params correctly #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: auth
wilsonianb
reviewed
Oct 14, 2022
| @@ -445,7 +445,7 @@ describe('Grant Routes', (): void => { | |||
| ) | |||
|
|
|||
| const redirectUrl = new URL(config.identityServerDomain) | |||
| redirectUrl.searchParams.set('interactRef', grant.interactRef) | |||
| redirectUrl.searchParams.set('interactId', grant.interactId) | |||
There was a problem hiding this comment.
These were just changed in
| { | ||
| id: grant.interactId, | ||
| nonce: grant.interactNonce, | ||
| choice: GrantChoices.Accept |
There was a problem hiding this comment.
Add test for non-GrantChoices choice
njlie
force-pushed
the
nl-handle-grant-choices
branch
from
a8a6dc5 to
ff2502f
Compare
mkurapov
approved these changes
Oct 21, 2022
| @@ -265,15 +269,19 @@ async function acceptGrant( | |||
| ctx.body = { | |||
| error: 'request_denied' | |||
| } | |||
| return | |||
There was a problem hiding this comment.
Not related to the changes, but is it ok to use status = 400 above on L268 even though it's not listed as a possible returned status code in the Open API spec?
There was a problem hiding this comment.
Some of this stuff (to my recollection) was written before the OpenAPI spec was brought in, so it's more like an initial stab. There could be something to adding a response to the spec for unexpected stuff, but later I will go over all these responses and decide if they should conform to an existing response or a new one should be added to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
/acceptor/rejectgrant endpoints as a query param, so the handler has been modified to reflect that.Context
Checklist
fixes #number