Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace protocol in peerDependencies isn't replaced with shipit #2462

Open
jjenzz opened this issue May 24, 2024 · 1 comment
Open

workspace protocol in peerDependencies isn't replaced with shipit #2462

jjenzz opened this issue May 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jjenzz
Copy link

jjenzz commented May 24, 2024

Describe the bug

i am using the workspace:* protocol to manage deps in my monorepo. it gets replaced correctly in dependencies and devDependencies when i run auto shipit but not in peerDependencies.

here is an example package.json from when i was using changesets, and here is an example of a package.json shipped with auto.

To Reproduce

  • add a workspace:* protocol to a package in peerDependencies
  • run auto shipit

Expected behavior

i expected the workspace protocol to be replaced for all dependencies

Screenshots

https://www.npmjs.com/package/@tokenami/css/v/0.0.45?activeTab=code

Environment information:

"auto" version: v11.1.6
"git"  version: v2.39.3 (Apple Git-146)
"node" version: v21.7.3

Project Information:

✔ Repository:      tokenami/tokenami
✔ Author Name:     Jenna Smith
✔ Author Email:    [email protected]
✔ Current Version: v0.0.47
✔ Latest Release:  v0.0.47

✔ Labels configured on GitHub project 

GitHub Token Information:

✔ Token:            [Token starting with ghp_]
✔ Repo Permission:  admin
✔ User:             jjenzz
✔ API:              
✔ Enabled Scopes:   repo, write:packages
✔ Rate Limit:       4954/5000
@jjenzz jjenzz added the bug Something isn't working label May 24, 2024
@jjenzz
Copy link
Author

jjenzz commented May 25, 2024

looks like a lerna issue, and i see there are attempts to move the lerna peerDependency to the all-contributors plugin only so this might not be relevant then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant