Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for component size limits #690

Open
JordanForeman opened this issue Apr 26, 2022 · 0 comments · May be fixed by #691
Open

Add support for component size limits #690

JordanForeman opened this issue Apr 26, 2022 · 0 comments · May be fixed by #691
Labels
enhancement New feature or request

Comments

@JordanForeman
Copy link

Is your feature request related to a problem? Please describe.

I want to define a perf budget in the form of a maximum component size. ds size allows me to set thresholds for changesets, but not for a component totally.

Describe the solution you'd like

The ds size command presently only considers the diff in size between the current changeset and the current release. I believe that with some minimal changes, we should be able to support a size limit for components.

It would be ideal to be able to specify a size limit on a component-by-component basis. I'm super new to this codebase, but it seems like ds.config is system-wide. If it's possible to make component-specific configurations, then exposing a size.limit configuration for a given component that is enforced by ds size would be great. Barring that, setting a size.limit for all components should be feasible as well.

Describe alternatives you've considered

  • ds size will can result in a report being added to Pull Requests via comments. It's possible to enforce a size limit by refusing to approve PRs where a limit is surpassed. ie. team norms
  • Possible to author instrumentation that parses output of ds size and fails if a limit is surpassed

Additional context

👋

@JordanForeman JordanForeman added the enhancement New feature or request label Apr 26, 2022
@JordanForeman JordanForeman linked a pull request Apr 26, 2022 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant