Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove _firstdate and replace with minimum(::AbstractInterval) and similar for _lastdate #2

Open
oxinabox opened this issue Dec 7, 2020 · 0 comments · May be fixed by #12
Open

remove _firstdate and replace with minimum(::AbstractInterval) and similar for _lastdate #2

oxinabox opened this issue Dec 7, 2020 · 0 comments · May be fixed by #12
Labels
good first issue Good for newcomers

Comments

@oxinabox
Copy link
Member

oxinabox commented Dec 7, 2020

There is a long standarding TODO in the code to remove do this,
now that invenia/Intervals.jl#141 is done we can.
@oxinabox oxinabox added the good first issue Good for newcomers label Dec 7, 2020
@oxinabox oxinabox mentioned this issue Dec 7, 2020
Merged
@oxinabox oxinabox changed the title remove _firstdate and replace with minimum(::AbstractInterval) remove _firstdate and replace with minimum(::AbstractInterval) and similar for _lastdate Dec 7, 2020
@Arvind-Maan Arvind-Maan linked a pull request Dec 30, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Interval Min/Max function invenia/DateSelectors.jl
1 participant
@oxinabox