Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Chained Transform #35

Closed
glennmoy opened this issue Mar 1, 2021 · 0 comments
Closed

Implement Chained Transform #35

glennmoy opened this issue Mar 1, 2021 · 0 comments
Labels
design new transform New transform request

Comments

@glennmoy
Copy link
Member

glennmoy commented Mar 1, 2021

It might be convenient to enable multiple Transforms to be applied in a Chain (cf https://invenia.github.io/Impute.jl/stable/api/chain/).

However there are a number of caveats/challenges to this that we would first have to address:

  1. There is no way to propagate the required kwargs for each component transform unless they were part of the constructor. (this is the most limiting aspect).
  2. The chain would only be mutating iff all the component transforms were mutating.
  3. Unless all component transforms are mutating, successive transforms could only be applied to the result of the previous one. e.g. if we applied one transform to some subset of the data (say combining cols :a and :b) that is non-mutating then we would be restricted to working with just that result from there on. We could not use it with the parent data anymore.

#38 applies to points (2) and (3).

There are probably numerous other issues I'm not thinking of right now.

@glennmoy glennmoy added design new transform New transform request labels Mar 2, 2021
@glennmoy glennmoy changed the title Implement Chain Transform Implement Chained Transform Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design new transform New transform request
Projects
None yet
Development

No branches or pull requests

1 participant