New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non mutating apply should return a DataFrame if using `[[:x]]` #55

Closed

glennmoy opened this issue Mar 17, 2021 · 0 comments · Fixed by #61

Assignees

Member

glennmoy commented Mar 17, 2021

This is the DataFrame API

julia> FeatureTransforms.apply(df, p; cols=[:a])
1-element Array{Array{Int64,1},1}:
 [1, 8, 27, 64, 125]

julia> FeatureTransforms.apply(df, p; cols=[[:a]])
1-element Array{Array{Array{Int64,1},1},1}:
 [[1, 8, 27, 64, 125]]

glennmoy self-assigned this

This was referenced Mar 22, 2021

Comply with DataFrames indexing syntax #60

Closed

Return consistent table type #61

Merged

glennmoy closed this as completed in #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment