Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default value for append_dim as dims inside apply_append #70

Open
glennmoy opened this issue Mar 31, 2021 · 0 comments
Open

Set default value for append_dim as dims inside apply_append #70

glennmoy opened this issue Mar 31, 2021 · 0 comments

Comments

@glennmoy
Copy link
Member

Looking at some tests repeating dims=x, append_dim=x made me think, would it make sense to set the default value for append_dim as dims inside the function? Maybe that only works when dims is single, as is currently the case.

Originally posted by @bencottier in #69 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glennmoy