Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dims arg to Filter apply when there are no missings #112

Closed
bencottier opened this issue Mar 26, 2021 · 0 comments · Fixed by #113
Closed

Allow dims arg to Filter apply when there are no missings #112

bencottier opened this issue Mar 26, 2021 · 0 comments · Fixed by #113

Comments

@bencottier
Copy link
Contributor

bencottier commented Mar 26, 2021

Use cases for Filter may be agnostic to whether the data allows missing values, and therefore they will pass the dims kwarg.

For example:

using Impute

function my_apply(data::AbstractArray, f::Filter; dims)
    # data may or may not allow/have missing values
    Impute.apply(data, f; dims=dims)
end

If data does not allow missing, the apply will dispatch to the table method and throw a MethodError.

To get the appropriate method, we therefore need to add kwargs... to it.

@bencottier bencottier changed the title Allow dims arg to filter() when there are no missings Allow dims arg to Filter apply when there are no missings Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant