Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot automerge - automatically merge minor changes too #1065

Open
mcm1957 opened this issue Oct 8, 2023 · 2 comments
Open

Dependabot automerge - automatically merge minor changes too #1065

mcm1957 opened this issue Oct 8, 2023 · 2 comments

Comments

@mcm1957
Copy link
Contributor

mcm1957 commented Oct 8, 2023

Currently our standard setup for dependabot automerge is configure as following:

update change - merge into devDependencies and (prod-) dependencies
minor change - merge into devDependencies but NOT into (prod-) dependencies
major change - do NOT merge at all

As discussion at telegramm (near https://t.me/ioBroker_development/31787) shows that almost all dependencies are configured using '^m.b.u' syntax. This way any minor update is installed at user systems whenever a new minor version exists and is used by at least one npm package. So ist does not realy seem to provide any benefit to require the devs to manually trigger such merges at adapetr directory.

SUGGESTION:
merge update and minor changes for devDependencies and (prod-)dependencies automatically (if tests succeed)
do nor merge major changes automatically (= no change)

Please review / discuss.I can provide a PR ich change is accepted. Feel free to assign to me.

@AlCalzone
Copy link
Collaborator

While I agree, I really want to avoid ~a.b.c versions getting auto-updated to a different minor version without the dev being involved, as preventing this is the sole reason for the ~ specifier. If we can avoid this, go for it.

@mcm1957
Copy link
Contributor Author

mcm1957 commented Oct 9, 2023

Absoliutly my oppinion too.
If ~cannot be expluded from automatic merge, we should leave it as it is.

I'll check as soon as I have time :-(

@mcm1957 mcm1957 changed the title Dependabot automerge - autmatically merge minor changes too Dependabot automerge - aut0matically merge minor changes too Oct 10, 2023
@mcm1957 mcm1957 changed the title Dependabot automerge - aut0matically merge minor changes too Dependabot automerge - automatically merge minor changes too Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants