-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter does not work with nodejs 20 #449
Comments
Is debug showing more? |
pS: What is the setting? an ip or a name? what is set as dns order for conroller? ipv4 or ipv6? |
PPS: Please start adapter on cli with "iob debug tr-064.0" and post output. There could be more logs |
Settings: Hostname fritz.box or IP 192.168.178.1 makes no difference.
Debugger shows:
|
As comparison a debug with nodejs 18.16.0
|
Looks to me as if
works in nodejs@18 while it fails with nodejs@20:
|
That "set template" is just an internal thing, so is notthe same. The call that fails is the call to get the TR0654 dewcription URL ... so (even if not 100% same lib becaus ethe soef sources disappeared from github but like https://github.com/hendrikw01/tr-064/blob/master/lib/TR064.js#L17 ... means that the request to http://IP:PORT/tr64desc.xml is returning no error but also no body ... I would strat ading maybe a bit more debug there to find out what happens. In fact nodejs 20 changelog did not directly report such topics as deprecations ... https://nodejs.org/en/blog/announcements/v20-release-announce |
Even on 'silly' there is nothing interesting to see, afaics
|
Maybe the parsing via xml2js is broken. Push dep to [email protected]. ? |
you could try locally ... we could start toadd logging to see where it breaks |
Sorry, I have no idea on how to do that. |
Just tested nodejs 20.4.0 |
Ok with now 3 adapters with these symptoms we assume it is because of the library "request" that is used ... we will deeper research |
@Grothesk242 welches OS nutzt du? |
@Grothesk242 nutzt du bookworm? Da bekomme ich die gleichen Fehler, mit bullseye gibt es keine Probleme mit node20. Mit node18 und bookworm gibt es keine Probleme mit dem Adapter |
Ja, bookworm 64bit auf einem Rpi4 8GB
Beim nuki-extended habe ich ein ähnliches Verhalten: iobroker-community-adapters/ioBroker.nuki-extended#281 Beide Adapter kommen mit [email protected] daher. Andere Adapter, die auch 'request' in den Deps haben laufen allerdings, soweit ich das sehe. |
@Grothesk242 habe dir ne patch Anleitung im Forum gesendet, bitte mal testen und berichten |
Funktioniert! |
Bitte mal den Patch rückgängig machen und Sentry in der Instanz ausschalten, das sollte es tun |
Disabling Sentry makes the adapter start without the errors. Edit: Works! |
related getsentry/sentry-javascript#8552 |
node 20.6.0 solved the issue for me, sentry can be activated again :-) |
Working with nodejs 20.6.0 |
thanks for reporting back! |
With nodejs@20 the adapter won't start, with node-Versions <20 everything works just fine:
The text was updated successfully, but these errors were encountered: