Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through the codebase and check all ignored tests, if they should be reenabled #4320

Open
bingyanglin opened this issue Dec 2, 2024 · 4 comments
Assignees
Labels
node Issues related to the Core Node team

Comments

@bingyanglin
Copy link
Contributor

bingyanglin commented Dec 2, 2024

Check all the ignored tests, and then investigate if they should be reenabled.

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Dec 2, 2024
@gokhan-simsek-iota gokhan-simsek-iota self-assigned this Dec 6, 2024
@gokhan-simsek-iota
Copy link

There seems to be 8 ignored tests . I have checked, they are also ignored in latest sui.
Here is the summary:

8 results - 7 files

crates/iota/src/unit_tests/profiler_tests.rs:
    #[ignore]
    #[cfg(feature = "gas-profiler")]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_profiler() {


crates/iota-benchmark/tests/simtest.rs:
     // TODO add this back once flakiness is resolved
     #[ignore]
     #[sim_test(config = "test_config()")]
     async fn test_simulated_load_pruning() {


crates/iota-core/src/checkpoints/checkpoint_executor/tests.rs:
    /// on correctly inserting transactions, especially the change_epoch tx. As it
    /// stands, this is better tested in existing reconfig simtests
    #[tokio::test]
    #[ignore]
    pub async fn test_checkpoint_executor_cross_epoch() {

    /// on correctly inserting transactions, especially the change_epoch tx. As it
    /// stands, this is better tested in existing reconfig simtests
    #[tokio::test]
    #[ignore]
    pub async fn test_reconfig_crash_recovery() {


crates/iota-e2e-tests/tests/traffic_control_tests.rs:
    #[ignore]
    #[sim_test]
    async fn test_traffic_sketch_with_slow_blocks() {


crates/iota-replay/src/tests.rs:
    /// Checks that replaying the latest tx on each testnet and mainnet does not
    /// fail
    #[ignore]
    #[tokio::test]
    async fn verify_latest_tx_replay_testnet_mainnet() {


crates/iota-source-validation-service/tests/tests.rs:
    #[allow(clippy::await_holding_lock)]
    #[tokio::test]
    #[ignore]
    async fn test_end_to_end() -> anyhow::Result<()> {


external-crates/move/crates/bytecode-verifier-tests/src/unit_tests/catch_unwind.rs:
    #[ignore]
    #[test]
    fn test_unwind() {

@gokhan-simsek-iota
Copy link

gokhan-simsek-iota commented Dec 6, 2024

I did try to understand them but, I think we need a more experienced eye to decide if they should be re-enabled.

@thibault-martinez
Copy link
Member

FYI we were/are already investigating them here #2045

@miker83z
Copy link
Contributor

miker83z commented Dec 11, 2024

Could this be in your scope? #4450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Issues related to the Core Node team
Projects
None yet
Development

No branches or pull requests

4 participants