Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of a map gets determined the first time something gets assigned
to it. As the arguments to
kstack/ustack
only get evaluated in thelast pass the map will be created with the default stack type, not the
one specified by the user.
Due to the way stacks work, with the hidden stack map and the user map
that holds the stack id, this only shows up when trying to print the
map. The type associated with the user map has the correct stack type,
but the original map has the default. This eventually leads to a SEGV.
Simple repro:
As this call expects literals we don't have to worry about variables and
thing that might be evaluated later, so we can just remove the
is_final_pass()
check.This fixes #1523
Checklist
CHANGELOG.md