Improve handling empty attach points #2179

viktormalik · 2022-04-01T07:47:17Z

If there are empty attach points for a probe, ignore them unless there
are no other non-empty attach points. In such a case, emit error.

This allows usage of trailing commas:

kprobe:function1,
kprobe:function2,
{...}

Fixes #2120.

Checklist

Language changes are updated in man/adoc/bpftrace.adoc and if needed in docs/reference_guide.md
User-visible and non-trivial changes updated in CHANGELOG.md
The new behaviour is covered by tests

If there are empty attach points for a probe, ignore them unless there are no other non-empty attach points. In such a case, emit error. This allows usage of trailing commas: kprobe:function1, kprobe:function2, {...}

viktormalik force-pushed the empty-aps branch from 4d2f791 to 34aec8b Compare April 1, 2022 07:48

Improve handling empty attach points

b77f95c

If there are empty attach points for a probe, ignore them unless there are no other non-empty attach points. In such a case, emit error. This allows usage of trailing commas: kprobe:function1, kprobe:function2, {...}

viktormalik force-pushed the empty-aps branch from 34aec8b to b77f95c Compare April 4, 2022 05:18

fbs approved these changes Apr 5, 2022

View reviewed changes

viktormalik merged commit a97c0eb into bpftrace:master Apr 5, 2022

viktormalik deleted the empty-aps branch May 3, 2022 04:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve handling empty attach points #2179

Improve handling empty attach points #2179

viktormalik commented Apr 1, 2022 •

edited

Loading

Improve handling empty attach points #2179

Improve handling empty attach points #2179

Conversation

viktormalik commented Apr 1, 2022 • edited Loading

Checklist

viktormalik commented Apr 1, 2022 •

edited

Loading