Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vsm] wdpost: configurable pre-check timeouts / windowPost扇区pre-check timeout可配置化? #532

Closed
1 task
Fatman13 opened this issue Nov 21, 2022 · 5 comments · Fixed by #591
Closed
1 task
Assignees
Labels
C-need-testing Category: need testing enhancement New feature or request
Milestone

Comments

@Fatman13
Copy link
Contributor

是否可虑添加windowPost扇区pre-check timeout可配置化功能?

关联:

  # Maximum amount of time a proving pre-check can take for a sector. If the check times out the sector will be skipped
  # 
  # WARNING: Setting this value too low risks in sectors being skipped even though they are accessible, just reading the
  # test challenge took longer than this timeout
  # WARNING: Setting this value too high risks missing PoSt deadline in case IO operations related to this sector are
  # blocked (e.g. in case of disconnected NFS mount)
  #
  # type: Duration
  # env var: LOTUS_PROVING_SINGLECHECKTIMEOUT
  SingleCheckTimeout = "10m0s"

  # Maximum amount of time a proving pre-check can take for an entire partition. If the check times out, sectors in
  # the partition which didn't get checked on time will be skipped
  # 
  # WARNING: Setting this value too low risks in sectors being skipped even though they are accessible, just reading the
  # test challenge took longer than this timeout
  # WARNING: Setting this value too high risks missing PoSt deadline in case IO operations related to this partition are
  # blocked or slow
  #
  # type: Duration
  # env var: LOTUS_PROVING_PARTITIONCHECKTIMEOUT
  PartitionCheckTimeout = "20m0s"
@Fatman13 Fatman13 added enhancement New feature or request C-triage Category: need triage labels Nov 21, 2022
@Fatman13 Fatman13 changed the title [venus-sector-manager] windowPost扇区pre-check timeout可配置化? [vsm] wdpost: configurable pre-check timeouts / windowPost扇区pre-check timeout可配置化? Nov 28, 2022
@diwufeiwen diwufeiwen assigned diwufeiwen and unassigned 0x5459 Jan 12, 2023
@diwufeiwen diwufeiwen moved this to In Progress in venus-cluster Jan 12, 2023
@diwufeiwen diwufeiwen added this to the v0.5.0 milestone Jan 12, 2023
@0x5459 0x5459 modified the milestones: v0.5.0, v0.6.0 Jan 16, 2023
@0x5459 0x5459 removed the C-triage Category: need triage label Jan 30, 2023
@diwufeiwen
Copy link
Contributor

在目前的venus-cluster中有些超时没有实际意义,检查逻辑和lotus不一样

@Fatman13 Fatman13 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in venus-cluster Feb 3, 2023
@0x5459 0x5459 reopened this Feb 3, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in venus-cluster Feb 3, 2023
@Fatman13
Copy link
Contributor Author

Fatman13 commented Feb 3, 2023

diwufeiwen大佬说逻辑不一样?所以我前面关了一下。😂

@diwufeiwen
Copy link
Contributor

这个可以加的,目前部分超时控制无意义,意思就是需要长期打开

@0x5459
Copy link
Collaborator

0x5459 commented Feb 3, 2023

还有一个草稿 pr 关联了这个 issue

@Fatman13
Copy link
Contributor Author

Fatman13 commented Feb 3, 2023

这个可以加的,目前部分超时控制无意义,意思就是需要长期打开

哦哦,理解错了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-need-testing Category: need testing enhancement New feature or request
Projects
Status: No status
Status: Done
3 participants